[PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

[PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

[Julia Lawall]

I don't think the patch is correct, so I haven't bothered signing off on
it.  Probably the & is not correct in the IS_ERR call?

julia

---------- Forwarded message ----------
Date: Sat, 22 Apr 2017 06:09:26 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Simon Ho <simon.ho@conexant.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 cx2072x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/sound/soc/codecs/cx2072x.c
+++ b/sound/soc/codecs/cx2072x.c
@@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
 		&cx2072x_regmap);

 	if (IS_ERR(&cx2072x->regmap)) {
-		ret = PTR_ERR(cx2072x->regmap);
+		ret = PTR_ERR(&cx2072x->regmap);
 		dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
 		return ret;
 	}

Re: [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

[Takashi Iwai]

On Sat, 22 Apr 2017 00:14:57 +0200,
Julia Lawall wrote:
> 
> I don't think the patch is correct, so I haven't bothered signing off on
> it.  Probably the & is not correct in the IS_ERR call?

Yes, IS_ERR() was called with the wrong argument.  I fixed it now.

Note that it's no branch to be merged to upstream yet, it's just a
testing for the previously submitted patchset.

Simon, my latest version is found in topic/soc-cx2072x branch in sound
git tree:
  git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git

Please check that before the next submission.


thanks,

Takashi

> 
> julia
> 
> ---------- Forwarded message ----------
> Date: Sat, 22 Apr 2017 06:09:26 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings
> 
>  PTR_ERR should access the value just tested by IS_ERR
> 
> Semantic patch information:
>  There can be false positives in the patch case, where it is the call to
>  IS_ERR that is wrong.
> 
> Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> 
> CC: Simon Ho <simon.ho@conexant.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!
> 
>  cx2072x.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/sound/soc/codecs/cx2072x.c
> +++ b/sound/soc/codecs/cx2072x.c
> @@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
>  		&cx2072x_regmap);
> 
>  	if (IS_ERR(&cx2072x->regmap)) {
> -		ret = PTR_ERR(cx2072x->regmap);
> +		ret = PTR_ERR(&cx2072x->regmap);
>  		dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
>  		return ret;
>  	}
> 

Re: [alsa-devel] [PATCH] ASoC: fix odd_ptr_err.cocci warnings (fwd)

[Simon Ho]

On Sat, Apr 22, 2017 at 08:54:11AM +0200, Takashi Iwai wrote:
> On Sat, 22 Apr 2017 00:14:57 +0200,
> Julia Lawall wrote:
> > 
> > I don't think the patch is correct, so I haven't bothered signing off on
> > it.  Probably the & is not correct in the IS_ERR call?
> 
> Yes, IS_ERR() was called with the wrong argument.  I fixed it now.
> 
> Note that it's no branch to be merged to upstream yet, it's just a
> testing for the previously submitted patchset.
> 
> Simon, my latest version is found in topic/soc-cx2072x branch in sound
> git tree:
>   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
> 
> Please check that before the next submission.
> 
> 
> thanks,
> 
> Takashi
> 

I will merge this to my new patch, thank you for all your assistance.

Thanks,

Simon
> > 
> > julia
> > 
> > ---------- Forwarded message ----------
> > Date: Sat, 22 Apr 2017 06:09:26 +0800
> > From: kbuild test robot <fengguang.wu@intel.com>
> > To: kbuild@01.org
> > Cc: Julia Lawall <julia.lawall@lip6.fr>
> > Subject: [PATCH] ASoC: fix odd_ptr_err.cocci warnings
> > 
> >  PTR_ERR should access the value just tested by IS_ERR
> > 
> > Semantic patch information:
> >  There can be false positives in the patch case, where it is the call to
> >  IS_ERR that is wrong.
> > 
> > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci
> > 
> > CC: Simon Ho <simon.ho@conexant.com>
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > 
> > Please take the patch only if it's a positive warning. Thanks!
> > 
> >  cx2072x.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/sound/soc/codecs/cx2072x.c
> > +++ b/sound/soc/codecs/cx2072x.c
> > @@ -2183,7 +2183,7 @@ static int cx2072x_i2c_probe(struct i2c_
> >  		&cx2072x_regmap);
> > 
> >  	if (IS_ERR(&cx2072x->regmap)) {
> > -		ret = PTR_ERR(cx2072x->regmap);
> > +		ret = PTR_ERR(&cx2072x->regmap);
> >  		dev_err(&i2c->dev, "Failed to init regmap: %d\n", ret);
> >  		return ret;
> >  	}
> > 
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel