From: Johannes Thumshirn <jthumshirn@suse.de>
To: Colin King <colin.king@canonical.com>
Cc: Johannes Thumshirn <jth@kernel.org>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
fcoe-devel@open-fcoe.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static
Date: Tue, 25 Apr 2017 09:07:18 +0200 [thread overview]
Message-ID: <20170425070628.GA16843@linux-x5ow.site> (raw)
In-Reply-To: <20170424170418.9625-1-colin.king@canonical.com>
On Mon, Apr 24, 2017 at 06:04:18PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> These module parameter variables don't need global scope, make them static
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Looks good,
Acked-by: Johannes Thumshirn <jth@kernel.org>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-04-25 7:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 17:04 [PATCH] scsi: fcoe: make fcoe_e_d_tov and fcoe_r_a_tov static Colin King
2017-04-25 7:07 ` Johannes Thumshirn [this message]
2017-04-25 16:51 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425070628.GA16843@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=colin.king@canonical.com \
--cc=fcoe-devel@open-fcoe.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=jth@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox