RE: [PATCH 4.4 06/28] cifs: Do not send echoes before Negotiate is complete

Pavel Shilovskiy
2017-05-10T01:00:42Z

On Tue, May 9, 2017 5:13 AM, Ben Hutchings wrote:
> > commit 4fcd1813e640 ("Fix reconnect to not defer smb3 session
> > reconnect long after socket reconnect") added support for Negotiate
> > requests to be initiated by echo calls.
> >
> > To avoid delays in calling echo after a reconnect, I added the patch
> > introduced by the commit b8c600120fc8 ("Call echo service immediately
> > after socket reconnect").
>
> The second commit hasn't actually been applied to any stable branches (so this one didn't need to be). Should it be?

Yes, 2nd commit hasn't been applied to stable branches, but the proposed fix does the right thing anyway since it doesn't allow to call echo on connections before negotiate phase. The commit b8c600120fc8 ("Call echo service immediately after socket reconnect") just allows to trigger the wrong behavior easily. So, I think it is better to have the fix in stable branches.

Best regards,
Pavel Shilovsky