typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

[Guenter Roeck]

Hi Greg,

would you be open to accepting the tcpm [1] and tcpci [2] drivers into
drivers/staging for v4.12 ?

The drivers are not ready for prime time, yet there is interest by others
to have them available and to help improving the code. I could create a
repository/branch at github to enable that, but drivers/staging seems to be
a better approach.

Thanks,
Guenter

---
[1] https://patchwork.kernel.org/patch/9693861/
[2] https://patchwork.kernel.org/patch/9693863/

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

[Greg Kroah-Hartman]

On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote:
> Hi Greg,
> 
> would you be open to accepting the tcpm [1] and tcpci [2] drivers into
> drivers/staging for v4.12 ?

What's the rush?

> The drivers are not ready for prime time, yet there is interest by others
> to have them available and to help improving the code. I could create a
> repository/branch at github to enable that, but drivers/staging seems to be
> a better approach.

Sure, if you want to maintain it in the kernel, and send me patches that
way for changes, I'll be glad to take them into staging, just send me a
patch that adds them to the tree and I'll merge them for 4.12-rc1.

thanks,

greg k-h

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

[Guenter Roeck]

On Tue, Apr 25, 2017 at 07:37:42PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote:
> > Hi Greg,
> > 
> > would you be open to accepting the tcpm [1] and tcpci [2] drivers into
> > drivers/staging for v4.12 ?
> 
> What's the rush?
> 

It has been a long time, and it avoids duplicate work and submissions,
including for drivers depending on it, such as the fusb302 driver submitted
by Hans de Goede [1] for which we have a (not yet published) driver based on
tcpm as well. If for nothing else, it widens the audience.

> > The drivers are not ready for prime time, yet there is interest by others
> > to have them available and to help improving the code. I could create a
> > repository/branch at github to enable that, but drivers/staging seems to be
> > a better approach.
> 
> Sure, if you want to maintain it in the kernel, and send me patches that
> way for changes, I'll be glad to take them into staging, just send me a
> patch that adds them to the tree and I'll merge them for 4.12-rc1.
> 

Ok, will do.

Thanks,
Guenter

---
[1] https://lkml.org/lkml/2017/4/21/312

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

[Greg Kroah-Hartman]

On Tue, Apr 25, 2017 at 10:54:02AM -0700, Guenter Roeck wrote:
> On Tue, Apr 25, 2017 at 07:37:42PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote:
> > > Hi Greg,
> > > 
> > > would you be open to accepting the tcpm [1] and tcpci [2] drivers into
> > > drivers/staging for v4.12 ?
> > 
> > What's the rush?
> > 
> 
> It has been a long time, and it avoids duplicate work and submissions,
> including for drivers depending on it, such as the fusb302 driver submitted
> by Hans de Goede [1] for which we have a (not yet published) driver based on
> tcpm as well. If for nothing else, it widens the audience.

Ok, fair enough, send away!

And getting a sane fusb302 driver would be great.  The ones I have seen
are just so bad...

greg k-h

Re: typec: tcpm/tcpci drivers acceptable for drivers/staging in v4.12 ?

[Guenter Roeck]

On Tue, Apr 25, 2017 at 08:02:54PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 25, 2017 at 10:54:02AM -0700, Guenter Roeck wrote:
> > On Tue, Apr 25, 2017 at 07:37:42PM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 25, 2017 at 09:50:31AM -0700, Guenter Roeck wrote:
> > > > Hi Greg,
> > > > 
> > > > would you be open to accepting the tcpm [1] and tcpci [2] drivers into
> > > > drivers/staging for v4.12 ?
> > > 
> > > What's the rush?
> > > 
> > 
> > It has been a long time, and it avoids duplicate work and submissions,
> > including for drivers depending on it, such as the fusb302 driver submitted
> > by Hans de Goede [1] for which we have a (not yet published) driver based on
> > tcpm as well. If for nothing else, it widens the audience.
> 
> Ok, fair enough, send away!
> 
> And getting a sane fusb302 driver would be great.  The ones I have seen
> are just so bad...
> 

It should hopefully be less insane :-). Looking forward to get your feedback.
We are still trying to figure out if there is anything we have to watch out
for before we can make it available; it is currently sitting in a private
Android branch and we don't want to get into trouble. Most likely we are just
over-cautious. Should hopefully be a matter of days.

Thanks,
Guenter