From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1952468AbdDYWYX (ORCPT <rfc822;w@1wt.eu>);
        Tue, 25 Apr 2017 18:24:23 -0400
Received: from mga04.intel.com ([192.55.52.120]:12572 "EHLO mga04.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1948593AbdDYWYN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 25 Apr 2017 18:24:13 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.37,251,1488873600"; 
   d="scan'208";a="80820161"
Date: Tue, 25 Apr 2017 16:22:51 -0600
From: Vishal Verma <vishal.l.verma@intel.com>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "Williams, Dan J" <dan.j.williams@intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Jiang, Dave" <dave.jiang@intel.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>
Subject: Re: [PATCH] libnvdimm: fix phys_addr for nvdimm_clear_poison
Message-ID: <20170425222250.GC15722@omniknight.lm.intel.com>
References: <20170425211651.7640-1-toshi.kani@hpe.com>
 <20170425214422.GB15722@omniknight.lm.intel.com>
 <1493156958.26622.8.camel@hpe.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1493156958.26622.8.camel@hpe.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/25, Kani, Toshimitsu wrote:
> On Tue, 2017-04-25 at 15:44 -0600, Vishal Verma wrote:
> > On 04/25, Toshi Kani wrote:
[...]
> >
> > Should we be using nsio->res.start here or nsio->addr ?
> 
> nsio->addr is a virtual address.  We need to pass the physical address
> of this range.

I see - makes sense.
You can add
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>