From: Joonsoo Kim <js1304@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Minchan Kim <minchan@kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
linux-kernel@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v4 2/4] zram: implement deduplication in zram
Date: Wed, 26 Apr 2017 15:04:26 +0900 [thread overview]
Message-ID: <20170426060425.GC29773@js1304-desktop> (raw)
In-Reply-To: <20170426040243.GC673@jagdpanzerIV.localdomain>
On Wed, Apr 26, 2017 at 01:02:43PM +0900, Sergey Senozhatsky wrote:
> On (04/26/17 09:52), js1304@gmail.com wrote:
> [..]
> > <no-dedup>
> > Elapsed time: out/host: 88 s
> > mm_stat: 8834420736 3658184579 3834208256 0 3834208256 32889 0 0 0
> >
> > <dedup>
> > Elapsed time: out/host: 100 s
> > mm_stat: 8832929792 3657329322 2832015360 0 2832015360 32609 0 952568877 80880336
> >
> > It shows performance degradation roughly 13% and save 24% memory. Maybe,
> > it is due to overhead of calculating checksum and comparison.
>
> I like the patch set, and it makes sense. the benefit is, obviously,
> case-by-case. on my system I've managed to save just 60MB on a 2.7G
> data set, which is far less than I was hoping to save :)
>
>
> I usually do DIRECT IO fio performance test. JFYI, the results
> were as follows:
Could you share your fio test setting? I will try to re-generate the
result and analyze it.
I guess that contention happens due to same data page. Could you check
it?
Thanks.
next prev parent reply other threads:[~2017-04-26 6:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 0:52 [PATCH v4 0/4] zram: implement deduplication in zram js1304
2017-04-26 0:52 ` [PATCH v4 1/4] zram: introduce zram_entry to prepare dedup functionality js1304
2017-04-26 0:52 ` [PATCH v4 2/4] zram: implement deduplication in zram js1304
2017-04-26 2:14 ` Sergey Senozhatsky
2017-04-26 5:57 ` Joonsoo Kim
2017-04-26 6:29 ` Minchan Kim
2017-04-26 6:59 ` Joonsoo Kim
2017-04-26 7:21 ` Sergey Senozhatsky
2017-04-26 7:39 ` Minchan Kim
2017-04-26 7:12 ` Sergey Senozhatsky
2017-04-26 2:37 ` Sergey Senozhatsky
2017-04-26 5:59 ` Joonsoo Kim
2017-04-26 6:04 ` Sergey Senozhatsky
2017-04-26 4:02 ` Sergey Senozhatsky
2017-04-26 6:04 ` Joonsoo Kim [this message]
2017-04-26 6:21 ` Sergey Senozhatsky
2017-04-27 6:57 ` Joonsoo Kim
2017-04-27 7:46 ` Sergey Senozhatsky
2017-05-02 5:31 ` Joonsoo Kim
2017-04-26 4:28 ` Sergey Senozhatsky
2017-04-26 6:08 ` Joonsoo Kim
2017-04-26 6:14 ` Sergey Senozhatsky
2017-04-26 0:52 ` [PATCH v4 3/4] zram: make deduplication feature optional js1304
2017-04-26 0:52 ` [PATCH v4 4/4] zram: compare all the entries with same checksum for deduplication js1304
2017-04-27 7:49 ` [PATCH v4 0/4] zram: implement deduplication in zram Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426060425.GC29773@js1304-desktop \
--to=js1304@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox