From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1956245AbdDZHWL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Apr 2017 03:22:11 -0400
Received: from mail-pf0-f182.google.com ([209.85.192.182]:35948 "EHLO
        mail-pf0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1953163AbdDZHWB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Apr 2017 03:22:01 -0400
Date: Wed, 26 Apr 2017 16:21:47 +0900
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Minchan Kim <minchan@kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com
Subject: Re: [PATCH v4 2/4] zram: implement deduplication in zram
Message-ID: <20170426072147.GI673@jagdpanzerIV.localdomain>
References: <1493167946-10936-1-git-send-email-iamjoonsoo.kim@lge.com>
 <1493167946-10936-3-git-send-email-iamjoonsoo.kim@lge.com>
 <20170426021452.GA673@jagdpanzerIV.localdomain>
 <20170426055700.GA29773@js1304-desktop>
 <20170426062938.GA19907@bbox>
 <CAAmzW4OPANWFbwNUm6eEhANvcNMbH0QUtxq=B-KoLuse-KzJVw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAAmzW4OPANWFbwNUm6eEhANvcNMbH0QUtxq=B-KoLuse-KzJVw@mail.gmail.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On (04/26/17 15:59), Joonsoo Kim wrote:
[..]
> > Actually, I found it for the last review cycle but didn't say that
> > intentionally. Because it is also odd to me that pages_stored isn't
> > increased for same_pages so I thought we can fix it all.
> >
> > I mean:
> >
> > * normal page
> >         inc pages_stored
> >         inc compr_data_size
> > * same_page
> >         inc pages_stored
> >         inc same_pages
> > * dedup_page
> >         inc pages_stored
> >         inc dup_data_size
> >
> > IOW, pages_stored should be increased for every write IO.
> > But the concern is we have said in zram.txt
> >
> >  orig_data_size   uncompressed size of data stored in this disk.
> >                   This excludes same-element-filled pages (same_pages) since
> >                   no memory is allocated for them.
> >
> > So, we might be too late. :-(
> > What do you think about it?
> > If anyone doesn't have any objection, I want to correct it all.
> 
> I have no objection.
> If so, do I need to postpone this patchset until others are fixed?

this probably will mess with your series a lot. so I don't mind if you or
Minchan will send stats-fixup patch after the dedup series. may be/preferably
as the last patch in the series. but if you or Minchan want to fix stats
first, then I wouldn't mind either. I just don't make a big deal out of those
stats, a bunch of fun to know numbers. my 5cents.

	-ss