From: "Tobin C. Harding" <me@tobin.cc>
To: Ilia Sergachev <ilia.sergachev@unibas.ch>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] Staging: ks7010: style fix
Date: Wed, 26 Apr 2017 20:37:56 +1000 [thread overview]
Message-ID: <20170426103756.GF18468@eros> (raw)
In-Reply-To: <20170426083854.18813-1-ilia.sergachev@unibas.ch>
On Wed, Apr 26, 2017 at 10:38:54AM +0200, Ilia Sergachev wrote:
> Fix the style of block comments.
> Move trailing */ to a separate line.
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
You are doing well Ilia. A few nitpicks
- Your first subject was better (excluding the filname) :) it was more
descriptive.
- staging has a small 's'. You can verify with;
$ git log --pretty=oneline drivers/staging/ks7010/ks_wlan_net.c
- You may like to describe the problem first, then what the patch does
to fix it;
Documentation/process/submitting-patches.rst
Describe your problem. Whether your patch is a one-line bug fix or
5000 lines of a new feature, there must be an underlying problem that
motivated you to do this work. Convince the reviewer that there is a
problem worth fixing and that it makes sense for them to read past the
first paragraph.
...
Once the problem is established, describe what you are actually doing
about it in technical detail. It's important to describe the change
in plain English for the reviewer to verify that the code is behaving
as you intend it to.
The actual patch looks good to me.
Hope this helps,
Tobin.
next prev parent reply other threads:[~2017-04-26 10:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:59 [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev
2017-04-26 3:12 ` Tobin C. Harding
2017-04-26 8:18 ` [PATCH v2] Staging: ks7010: style fix Ilia Sergachev
2017-04-26 8:28 ` Greg Kroah-Hartman
2017-04-26 8:38 ` Ilia Sergachev
2017-04-26 10:37 ` Tobin C. Harding [this message]
2017-04-26 10:45 ` Dan Carpenter
2017-04-26 11:00 ` [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev
2017-04-26 22:50 ` Tobin C. Harding
2017-04-28 9:45 ` Greg Kroah-Hartman
2017-04-28 10:35 ` [PATCH v4] " Ilia Sergachev
2017-04-28 12:20 ` Greg Kroah-Hartman
2017-04-28 13:01 ` Ilia Sergachev
2017-04-30 9:11 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170426103756.GF18468@eros \
--to=me@tobin.cc \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilia.sergachev@unibas.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).