From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1754282AbdDZPux (ORCPT <rfc822;w@1wt.eu>);
        Wed, 26 Apr 2017 11:50:53 -0400
Received: from 8bytes.org ([81.169.241.247]:59999 "EHLO theia.8bytes.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753943AbdDZPuq (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 26 Apr 2017 11:50:46 -0400
Date: Wed, 26 Apr 2017 17:50:44 +0200
From: Joerg Roedel <joro@8bytes.org>
To: Robert Richter <rrichter@cavium.com>
Cc: Will Deacon <will.deacon@arm.com>,
        linux-arm-kernel@lists.infradead.org, iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iommu: Print a message with the default domain type
 created
Message-ID: <20170426155044.GA1332@8bytes.org>
References: <20170426143813.21225-1-rrichter@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170426143813.21225-1-rrichter@cavium.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Robert,

On Wed, Apr 26, 2017 at 04:38:13PM +0200, Robert Richter wrote:
> -	pr_info("Adding device %s to group %d\n", dev_name(dev), group->id);
> +	pr_info("Adding device %s to group %d, default domain type %d\n",
> +		dev_name(dev), group->id,
> +		group->default_domain ? group->default_domain->type : -1);

Printing just a number is not very user-friendly. We have only two
default domain-types right now, so it is sufficient to just print
additional information if a device is identity-mapped. Something like

	"Adding device %s to group %d - using identity mapping"


Regards,

	Joerg