public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kirill Tkhai <ktkhai@virtuozzo.com>
Cc: agruenba@redhat.com, keescook@chromium.org,
	linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
	viro@zeniv.linux.org.uk, oleg@redhat.com, paul@paul-moore.com,
	ebiederm@xmission.com, avagin@openvz.org,
	linux-fsdevel@vger.kernel.org, mtk.manpages@gmail.com,
	akpm@linux-foundation.org, luto@amacapital.net,
	gorcunov@openvz.org, mingo@kernel.org, serge@hallyn.com
Subject: Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy
Date: Thu, 27 Apr 2017 13:55:54 +0200	[thread overview]
Message-ID: <20170427115554.GA22360@kroah.com> (raw)
In-Reply-To: <149329053642.12846.16389129928422677700.stgit@localhost.localdomain>

On Thu, Apr 27, 2017 at 01:57:16PM +0300, Kirill Tkhai wrote:
> --- a/include/uapi/linux/nsfs.h
> +++ b/include/uapi/linux/nsfs.h
> @@ -14,5 +14,12 @@
>  #define NS_GET_NSTYPE		_IO(NSIO, 0x3)
>  /* Get owner UID (in the caller's user namespace) for a user namespace */
>  #define NS_GET_OWNER_UID	_IO(NSIO, 0x4)
> +/* Set a vector of ns_last_pid for a pid namespace stack */
> +#define NS_SET_LAST_PID_VEC	_IO(NSIO, 0x5)
> +
> +struct ns_ioc_pid_vec {
> +	unsigned int nr;

Please make this an explicit type, variables that cross the user/kernel
boundry should be using __u32 and friends, not vague things like "int".

thanks,

greg k-h

      reply	other threads:[~2017-04-27 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-27 10:57 [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy Kirill Tkhai
2017-04-27 11:55 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170427115554.GA22360@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=agruenba@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=gorcunov@openvz.org \
    --cc=keescook@chromium.org \
    --cc=ktkhai@virtuozzo.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mingo@kernel.org \
    --cc=mtk.manpages@gmail.com \
    --cc=oleg@redhat.com \
    --cc=paul@paul-moore.com \
    --cc=serge@hallyn.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox