From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1033993AbdD0L4S (ORCPT ); Thu, 27 Apr 2017 07:56:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37918 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030387AbdD0L4J (ORCPT ); Thu, 27 Apr 2017 07:56:09 -0400 Date: Thu, 27 Apr 2017 13:55:54 +0200 From: Greg KH To: Kirill Tkhai Cc: agruenba@redhat.com, keescook@chromium.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, viro@zeniv.linux.org.uk, oleg@redhat.com, paul@paul-moore.com, ebiederm@xmission.com, avagin@openvz.org, linux-fsdevel@vger.kernel.org, mtk.manpages@gmail.com, akpm@linux-foundation.org, luto@amacapital.net, gorcunov@openvz.org, mingo@kernel.org, serge@hallyn.com Subject: Re: [PATCH v2] pid_ns: Introduce ioctl to set vector of ns_last_pid's on ns hierarhy Message-ID: <20170427115554.GA22360@kroah.com> References: <149329053642.12846.16389129928422677700.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149329053642.12846.16389129928422677700.stgit@localhost.localdomain> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 27, 2017 at 01:57:16PM +0300, Kirill Tkhai wrote: > --- a/include/uapi/linux/nsfs.h > +++ b/include/uapi/linux/nsfs.h > @@ -14,5 +14,12 @@ > #define NS_GET_NSTYPE _IO(NSIO, 0x3) > /* Get owner UID (in the caller's user namespace) for a user namespace */ > #define NS_GET_OWNER_UID _IO(NSIO, 0x4) > +/* Set a vector of ns_last_pid for a pid namespace stack */ > +#define NS_SET_LAST_PID_VEC _IO(NSIO, 0x5) > + > +struct ns_ioc_pid_vec { > + unsigned int nr; Please make this an explicit type, variables that cross the user/kernel boundry should be using __u32 and friends, not vague things like "int". thanks, greg k-h