From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1034090AbdD0Mnc (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Apr 2017 08:43:32 -0400
Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:40725 "EHLO
        atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1031338AbdD0MnW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Apr 2017 08:43:22 -0400
Date: Thu, 27 Apr 2017 14:43:10 +0200
From: Pavel Machek <pavel@ucw.cz>
To: Jiri Slaby <jslaby@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/29] x86: assembly, use DATA_SIMPLE for data
Message-ID: <20170427124310.GC23352@amd>
References: <20170421141305.25180-1-jslaby@suse.cz>
 <20170421141305.25180-9-jslaby@suse.cz>
 <20170427115358.GB23352@amd>
 <84fc78c7-3a70-bf74-aa2c-c8b59e2adb3e@suse.cz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="nmemrqcdn5VTmUEE"
Content-Disposition: inline
In-Reply-To: <84fc78c7-3a70-bf74-aa2c-c8b59e2adb3e@suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--nmemrqcdn5VTmUEE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu 2017-04-27 14:30:05, Jiri Slaby wrote:
> Hi,
>=20
> On 04/27/2017, 01:53 PM, Pavel Machek wrote:
> >> @@ -91,11 +91,11 @@ ENDPROC(do_suspend_lowlevel)
> >> =20
> >>  .data
> >>  ALIGN
> >> -ENTRY(saved_magic)	.long	0
> >> -ENTRY(saved_eip)	.long	0
> >> +SYM_DATA_SIMPLE(saved_magic, .long 0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_eip, .long 0)
> >> =20
> >>  # saved registers
> >> -saved_idt:	.long	0,0
> >> -saved_ldt:	.long	0
> >> -saved_tss:	.long	0
> >> +SYM_DATA_SIMPLE_LOCAL(saved_idt, .long 0,0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_ldt, .long 0)
> >> +SYM_DATA_SIMPLE_LOCAL(saved_tss, .long 0)
> >=20
> > Do we really need to mark local data like that? It complicates the
> > source code a bit...
>=20
> Not really -- if the preferred way is not to annotate local symbols, I
> can indeed remove that.

I'd prefer that ;-).
									Pavel

--=20
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo=
g.html

--nmemrqcdn5VTmUEE
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlkB514ACgkQMOfwapXb+vIXCACdFrrn7kS1Z8iutlB6Oh7DqDLY
QC4An3t1kfl6NK83C/Hr+WbQwVtLX57z
=0dBH
-----END PGP SIGNATURE-----

--nmemrqcdn5VTmUEE--