From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Mera <dev@michaelmera.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Samuel Thibault <samuel.thibault@ens-lyon.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: speakup: fix wrong code indent
Date: Fri, 28 Apr 2017 09:11:46 +0200 [thread overview]
Message-ID: <20170428071146.GA27730@kroah.com> (raw)
In-Reply-To: <20170428062024.14887-1-dev@michaelmera.com>
On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote:
> Remove unecessary multiline comment, fixes checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Michael Mera <dev@michaelmera.com>
> ---
> drivers/staging/speakup/speakup_decpc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6bf38e49a96d..94ca6987f71b 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -84,9 +84,7 @@
> #define CTRL_last_index 0x0b00 /* get last index spoken */
> #define CTRL_io_priority 0x0c00 /* change i/o priority */
> #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */
> -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded
> - * languages
> - */
> +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */
And now you have a different coding style warning :(
Sorry, you can't replace one for another.
greg k-h
next prev parent reply other threads:[~2017-04-28 7:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 6:20 [PATCH] staging: speakup: fix wrong code indent Michael Mera
2017-04-28 7:11 ` Greg Kroah-Hartman [this message]
2017-04-28 8:46 ` [PATCH v2] " Michael Mera
2017-04-28 9:00 ` Greg Kroah-Hartman
2017-04-28 9:11 ` Michael Mera
2017-04-28 9:36 ` Greg Kroah-Hartman
2017-04-28 14:43 ` [PATCH v3] " Michael Mera
2017-04-28 15:52 ` Greg Kroah-Hartman
2017-04-29 1:24 ` Michael Mera
2017-05-09 23:48 ` [PATCH v4] staging: speakup: fix unnecessary long line Michael Mera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428071146.GA27730@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=chris@the-brannons.com \
--cc=dev@michaelmera.com \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox