From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939733AbdD1HMM (ORCPT ); Fri, 28 Apr 2017 03:12:12 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49540 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939562AbdD1HMJ (ORCPT ); Fri, 28 Apr 2017 03:12:09 -0400 Date: Fri, 28 Apr 2017 09:11:46 +0200 From: Greg Kroah-Hartman To: Michael Mera Cc: William Hubbs , Chris Brannon , Kirk Reiser , Samuel Thibault , linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: speakup: fix wrong code indent Message-ID: <20170428071146.GA27730@kroah.com> References: <20170428062024.14887-1-dev@michaelmera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428062024.14887-1-dev@michaelmera.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote: > Remove unecessary multiline comment, fixes checkpatch messages: > ERROR: code indent should use tabs where possible > WARNING: Block comments should align the * on each line > > Signed-off-by: Michael Mera > --- > drivers/staging/speakup/speakup_decpc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c > index 6bf38e49a96d..94ca6987f71b 100644 > --- a/drivers/staging/speakup/speakup_decpc.c > +++ b/drivers/staging/speakup/speakup_decpc.c > @@ -84,9 +84,7 @@ > #define CTRL_last_index 0x0b00 /* get last index spoken */ > #define CTRL_io_priority 0x0c00 /* change i/o priority */ > #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */ > -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded > - * languages > - */ > +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */ And now you have a different coding style warning :( Sorry, you can't replace one for another. greg k-h