Re: [PATCH v2] staging: speakup: fix wrong code indent

Michael Mera
2017-04-28T09:11:44Z

Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:

> On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
>> Remove unnecessary multiline comment, fixes checkpatch messages:
>> ERROR: code indent should use tabs where possible
>> WARNING: Block comments should align the * on each line
>>
>> Signed-off-by: Michael Mera <dev@michaelmera.com>
>> ---
>> drivers/staging/speakup/speakup_decpc.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> What changed from v1? That needs to go below the --- line.

Oh. Sorry. I fixed the spelling of the patch message, since I
though that was the problem you detected but...

>
> And I think my previous email still is relevant here...

... apparently not. I double checked the patch with 'checkpatch --strict'
and it does not detect any problem this time.

Sorry if I missed something obvious, I am quite new to this, but could
you give me some additional hint about the problem.