Re: [PATCH] staging: speakup: fix wrong code indent

Greg Kroah-Hartman
2017-04-28T07:12:12Z

On Fri, Apr 28, 2017 at 03:20:24PM +0900, Michael Mera wrote:
> Remove unecessary multiline comment, fixes checkpatch messages:
> ERROR: code indent should use tabs where possible
> WARNING: Block comments should align the * on each line
>
> Signed-off-by: Michael Mera <dev@michaelmera.com>
> ---
> drivers/staging/speakup/speakup_decpc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/speakup_decpc.c b/drivers/staging/speakup/speakup_decpc.c
> index 6bf38e49a96d..94ca6987f71b 100644
> --- a/drivers/staging/speakup/speakup_decpc.c
> +++ b/drivers/staging/speakup/speakup_decpc.c
> @@ -84,9 +84,7 @@
> #define CTRL_last_index 0x0b00 /* get last index spoken */
> #define CTRL_io_priority 0x0c00 /* change i/o priority */
> #define CTRL_free_mem 0x0d00 /* get free paragraphs on module */
> -#define CTRL_get_lang 0x0e00 /* return bit mask of loaded
> - * languages
> - */
> +#define CTRL_get_lang 0x0e00 /* return bitmask of loaded languages */

And now you have a different coding style warning :(

Sorry, you can't replace one for another.

greg k-h