From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1165058AbdD1JhG (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Apr 2017 05:37:06 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:35520 "EHLO
        mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754990AbdD1Jg5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Apr 2017 05:36:57 -0400
Date: Fri, 28 Apr 2017 11:36:47 +0200
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Michael Mera <dev@michaelmera.com>
Cc: William Hubbs <w.d.hubbs@gmail.com>,
        Chris Brannon <chris@the-brannons.com>, Kirk Reiser <kirk@reisers.ca>,
        Samuel Thibault <samuel.thibault@ens-lyon.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: speakup: fix wrong code indent
Message-ID: <20170428093647.GA30688@kroah.com>
References: <20170428071146.GA27730@kroah.com>
 <20170428084607.21405-1-dev@michaelmera.com>
 <20170428090034.GA3436@kroah.com>
 <87bmrgj3rr.fsf@michaelmera.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87bmrgj3rr.fsf@michaelmera.com>
User-Agent: Mutt/1.8.2 (2017-04-18)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Apr 28, 2017 at 06:11:04PM +0900, Michael Mera wrote:
> Greg Kroah-Hartman <gregkh@linuxfoundation.org> writes:
> 
> > On Fri, Apr 28, 2017 at 05:46:07PM +0900, Michael Mera wrote:
> >> Remove unnecessary multiline comment, fixes checkpatch messages:
> >> ERROR: code indent should use tabs where possible
> >> WARNING: Block comments should align the * on each line
> >> 
> >> Signed-off-by: Michael Mera <dev@michaelmera.com>
> >> ---
> >>  drivers/staging/speakup/speakup_decpc.c | 4 +---
> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > What changed from v1?  That needs to go below the --- line.
> 
> Oh. Sorry. I fixed the spelling of the patch message, since I
> though that was the problem you detected but...
> 
> >
> > And I think my previous email still is relevant here...
> 
> ... apparently not. I double checked the patch with 'checkpatch --strict'
> and it does not detect any problem this time.
> 
> Sorry if I missed something obvious, I am quite new to this, but could
> you give me some additional hint about the problem.

Isn't the line now too long?

Anyway, please resend with at least the properly version information.

thanks,

greg k-h