From: Greg KH <gregkh@linuxfoundation.org>
To: Karim Eshapa <karim.eshapa@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings.
Date: Fri, 28 Apr 2017 12:02:58 +0200 [thread overview]
Message-ID: <20170428100258.GA4276@kroah.com> (raw)
In-Reply-To: <1493223340-13794-1-git-send-email-karim.eshapa@gmail.com>
On Wed, Apr 26, 2017 at 06:15:40PM +0200, Karim Eshapa wrote:
> Fixing sparse warnings incorrect type assignment.
>
> Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index 6134eba..cf6bf65 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -3511,20 +3511,24 @@ static void hfa384x_int_rxmonitor(struct wlandevice *wlandev,
> datap = skb_put(skb, sizeof(struct p80211_caphdr));
> caphdr = (struct p80211_caphdr *)datap;
>
> - caphdr->version = htonl(P80211CAPTURE_VERSION);
> - caphdr->length = htonl(sizeof(struct p80211_caphdr));
> + caphdr->version = __be32_to_cpu(htonl(P80211CAPTURE_VERSION));
> + caphdr->length = __be32_to_cpu( htonl(sizeof(
> + struct p80211_caphdr)));
How do you know this is correct? And why the odd ' ' usage? I can't
take this patch for that reason alone...
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-28 10:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 16:15 [PATCH] drivers:staging:wlan-ng:hfa384x_usb: Fixing sparse warnings Karim Eshapa
2017-04-28 10:02 ` Greg KH [this message]
2017-04-30 16:26 ` Karim Eshapa
2017-05-07 18:39 ` [PATCH] " Arnd Bergmann
2017-05-10 13:15 ` Karim Eshapa
2017-05-12 8:07 ` Greg KH
2017-05-12 12:47 ` Karim Eshapa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428100258.GA4276@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=karim.eshapa@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox