From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992629AbdD1KbA (ORCPT ); Fri, 28 Apr 2017 06:31:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37840 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1948443AbdD1Kat (ORCPT ); Fri, 28 Apr 2017 06:30:49 -0400 Date: Fri, 28 Apr 2017 12:29:55 +0200 From: Greg Kroah-Hartman To: Marcos Paulo de Souza Cc: devel@driverdev.osuosl.org, Elise Lennion , Arnd Bergmann , linux-kernel@vger.kernel.org, Tobias Klauser , simran singhal , Bhumika Goyal Subject: Re: [PATCH] staging: rtl8192u: Fix sparse warning Message-ID: <20170428102955.GA20343@kroah.com> References: <20170423205229.6347-1-marcos.souza.org@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170423205229.6347-1-marcos.souza.org@gmail.com> User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote: > Fix the following sparse warning: > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in assignment (different base types) > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: expected restricted __le16 > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: got unsigned short [unsigned] [usertype] > > Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into cpu type. > > Signed-off-by: Marcos Paulo de Souza > --- > > Sorry, I don't have the hardware to test, so please review and tell me if I'm wrong in this one! Patch doesn't apply to my tree at all :(