From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ilia Sergachev <ilia.sergachev@unibas.ch>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] staging: ks7010: fix block comment style
Date: Fri, 28 Apr 2017 14:20:21 +0200 [thread overview]
Message-ID: <20170428122021.GA16742@kroah.com> (raw)
In-Reply-To: <20170428103555.1999-1-ilia.sergachev@unibas.ch>
On Fri, Apr 28, 2017 at 12:35:55PM +0200, Ilia Sergachev wrote:
> Checkpatch was showing:
> WARNING: Block comments use a trailing */ on a separate line.
>
> Move trailing */ to a separate line.
>
> Signed-off-by: Ilia Sergachev <ilia.sergachev@unibas.ch>
> ---
> Changes for v4:
> - remove one trailing whitespace in the last hunk,
> which was corrupting the patch
Nope, the whole thing still doesn't apply:
checking file drivers/staging/ks7010/ks_wlan_net.c
Hunk #1 FAILED at 230.
Hunk #2 FAILED at 343.
Hunk #3 FAILED at 1137.
Hunk #4 FAILED at 1189.
Hunk #5 FAILED at 1225.
Hunk #6 FAILED at 1497.
Hunk #7 FAILED at 1569.
Hunk #8 FAILED at 1596.
Hunk #9 FAILED at 1970.
Hunk #10 FAILED at 2105.
Hunk #11 FAILED at 3351.
11 out of 11 hunks FAILED
What tree/branch are you making this patch against?
thanks,
greg k-h
next prev parent reply other threads:[~2017-04-28 12:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:59 [PATCH] staging: ks7010: fix block comment style in ks_wlan_net.c Ilia Sergachev
2017-04-26 3:12 ` Tobin C. Harding
2017-04-26 8:18 ` [PATCH v2] Staging: ks7010: style fix Ilia Sergachev
2017-04-26 8:28 ` Greg Kroah-Hartman
2017-04-26 8:38 ` Ilia Sergachev
2017-04-26 10:37 ` Tobin C. Harding
2017-04-26 10:45 ` Dan Carpenter
2017-04-26 11:00 ` [PATCH v3] staging: ks7010: fix block comment style Ilia Sergachev
2017-04-26 22:50 ` Tobin C. Harding
2017-04-28 9:45 ` Greg Kroah-Hartman
2017-04-28 10:35 ` [PATCH v4] " Ilia Sergachev
2017-04-28 12:20 ` Greg Kroah-Hartman [this message]
2017-04-28 13:01 ` Ilia Sergachev
2017-04-30 9:11 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428122021.GA16742@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=ilia.sergachev@unibas.ch \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).