From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164876AbdD1Qwj (ORCPT ); Fri, 28 Apr 2017 12:52:39 -0400 Received: from foss.arm.com ([217.140.101.70]:51438 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939603AbdD1Qwc (ORCPT ); Fri, 28 Apr 2017 12:52:32 -0400 Date: Fri, 28 Apr 2017 17:52:32 +0100 From: Will Deacon To: Geert Uytterhoeven Cc: Geert Uytterhoeven , Catalin Marinas , Kevin Hilman , Mark Brown , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] arm64: Print DT machine model in setup_machine_fdt() Message-ID: <20170428165232.GZ13675@arm.com> References: <1493296385-14140-1-git-send-email-geert+renesas@glider.be> <20170428145730.GS13675@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 06:16:46PM +0200, Geert Uytterhoeven wrote: > On Fri, Apr 28, 2017 at 4:57 PM, Will Deacon wrote: > > On Thu, Apr 27, 2017 at 02:33:05PM +0200, Geert Uytterhoeven wrote: > >> On arm32, the machine model specified in the device tree is printed > >> during boot-up, courtesy of of_flat_dt_match_machine(). > >> > >> On arm64, of_flat_dt_match_machine() is not called, and the machine > >> model information is not available from the kernel log. > >> > >> Print the machine model to make it easier to derive the machine model > >> from an arbitrary kernel boot log. > >> > >> Signed-off-by: Geert Uytterhoeven > >> --- > >> I have scripts to save kernel boot logs, and compare logs[*] for > >> subsequent boots on the same machine. Having a way to extract the > >> machine model from an arbitrary kernel boot log makes this easier. > > > I think your use-case is slightly questionable (e.g. for ACPI, we print > > something different, and this isn't generally considered to be ABI), but > > the patch is harmless and if you find it useful then: > > Not having access to an ARM ACPI system, what does it print for example? It's supposed to print out some stuff from DMI, but my Juno just says: DMI not present or invalid. Luckily, it's not really an issue because I don't get to a prompt after USB fails to come up and it times out mounting the rootfs. Will