From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Input: twl4030-pwrbutton: use correct device for irq request
Date: Fri, 28 Apr 2017 10:27:50 -0700 [thread overview]
Message-ID: <20170428172750.GD4949@dtor-ws> (raw)
In-Reply-To: <20170428122855.3185-1-sebastian.reichel@collabora.co.uk>
On Fri, Apr 28, 2017 at 02:28:54PM +0200, Sebastian Reichel wrote:
> The interrupt should be requested for the platform device
> and not for the input device.
>
> Fixes: 7f9ce649d267 ("Input: twl4030-pwrbutton - simplify driver using devm_*")
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Applied, thank you.
> ---
> drivers/input/misc/twl4030-pwrbutton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/misc/twl4030-pwrbutton.c b/drivers/input/misc/twl4030-pwrbutton.c
> index 54162d2cbcfc..7c4504c31b07 100644
> --- a/drivers/input/misc/twl4030-pwrbutton.c
> +++ b/drivers/input/misc/twl4030-pwrbutton.c
> @@ -70,7 +70,7 @@ static int twl4030_pwrbutton_probe(struct platform_device *pdev)
> pwr->phys = "twl4030_pwrbutton/input0";
> pwr->dev.parent = &pdev->dev;
>
> - err = devm_request_threaded_irq(&pwr->dev, irq, NULL, powerbutton_irq,
> + err = devm_request_threaded_irq(&pdev->dev, irq, NULL, powerbutton_irq,
> IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING |
> IRQF_ONESHOT,
> "twl4030_pwrbutton", pwr);
> --
> 2.11.0
>
--
Dmitry
prev parent reply other threads:[~2017-04-28 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 12:28 [PATCH 1/2] Input: twl4030-pwrbutton: use correct device for irq request Sebastian Reichel
2017-04-28 12:28 ` [PATCH 2/2] Input: twl4030-pwrbutton: Use input_set_capability() helper Sebastian Reichel
2017-04-28 17:28 ` Dmitry Torokhov
2017-04-28 17:27 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170428172750.GD4949@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox