From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1166239AbdD2Fi0 (ORCPT ); Sat, 29 Apr 2017 01:38:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38390 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1166211AbdD2FiR (ORCPT ); Sat, 29 Apr 2017 01:38:17 -0400 Date: Sat, 29 Apr 2017 07:33:53 +0200 From: Greg Kroah-Hartman To: Julius Werner Cc: LKML , Thierry Escande , Dmitry Torokhov , Aaron Durbin Subject: Re: [PATCH] firmware: google: memconsole: Adapt to new coreboot ring buffer format Message-ID: <20170429053353.GA11491@kroah.com> References: <20170427205917.18392-1-jwerner@chromium.org> <20170428071443.GC27859@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 01:44:45PM -0700, Julius Werner wrote: > > -------------------------8<-------------------------------------------- > > That needs to go below the --- line, not above it. > > > Really? git am --scissors seems to do the right thing for me this way... Ah, never used that option before, it's not part of my normal workflow. > Anyway, it was only an FYI, I'll just leave it out. >   > > When you say things like "in addition" and "finally", that implies that > the code needs to be broken up into multiple patches.  Rememeber, each > patch only should ever do 1 thing. > > > Well... all these things are required to make the new format work. But I can > split them up further if you like.  Please do, makes it easier to review, right? thanks, greg k-h