From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S3000605AbdD3JL4 (ORCPT ); Sun, 30 Apr 2017 05:11:56 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57071 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164020AbdD3JLw (ORCPT ); Sun, 30 Apr 2017 05:11:52 -0400 X-ME-Sender: X-Sasl-enc: xNxPXAVmU3jEYFy67mnBMKNal/X9ouOa0ewA/wjAObNP 1493543511 Date: Sun, 30 Apr 2017 19:11:48 +1000 From: "Tobin C. Harding" To: Ilia Sergachev Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] staging: ks7010: fix block comment style Message-ID: <20170430091148.GD14735@eros> References: <20170425205925.20439-1-ilia.sergachev@unibas.ch> <20170428103555.1999-1-ilia.sergachev@unibas.ch> <20170428122021.GA16742@kroah.com> <20170428150132.0082f449@zero1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428150132.0082f449@zero1> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 28, 2017 at 03:01:32PM +0200, Ilia Sergachev wrote: > On Fri, 28 Apr 2017 14:20:21 +0200 > Greg Kroah-Hartman wrote: > > > > > Nope, the whole thing still doesn't apply: > > > > checking file drivers/staging/ks7010/ks_wlan_net.c > > Hunk #1 FAILED at 230. > > Hunk #2 FAILED at 343. > > Hunk #3 FAILED at 1137. > > Hunk #4 FAILED at 1189. > > Hunk #5 FAILED at 1225. > > Hunk #6 FAILED at 1497. > > Hunk #7 FAILED at 1569. > > Hunk #8 FAILED at 1596. > > Hunk #9 FAILED at 1970. > > Hunk #10 FAILED at 2105. > > Hunk #11 FAILED at 3351. > > 11 out of 11 hunks FAILED > > > > What tree/branch are you making this patch against? > > > > thanks, > > > > greg k-h > > Ok, I was using torvalds/linux instead of next/linux-next. > In fact, the style fixes on this file were already done in 'next'. > So, thank you all for your patience, and sorry about lost time, > these were the necessary lessons for me - I'll find now something else > to fix :) If you are attempting fixes to staging drivers you may like to base your patches off Greg's staging tree https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ The branch you want is either staging-next or staging-testing. Hope this helps, Tobin.