From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbdEAVbt (ORCPT ); Mon, 1 May 2017 17:31:49 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55999 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbdEAVbo (ORCPT ); Mon, 1 May 2017 17:31:44 -0400 X-ME-Sender: X-Sasl-enc: aNBoA/QOu/FAyBAEw1V2EnQbxya/O989ctMBzNGEriWM 1493674297 Date: Tue, 2 May 2017 07:31:34 +1000 From: "Tobin C. Harding" To: gapalinux Cc: gregkh@linuxfoundation.org, wsa@the-dreams.de, karniksayli1995@gmail.com, shiva@exdev.nl, bhumirks@gmail.com, mattkilgore12@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging/ks7010: Fix type assignment for struct hostif_hdr Message-ID: <20170501213134.GA6132@eros> References: <1493488470-13487-1-git-send-email-gapalinux@gmail.com> <20170501095944.GL21332@eros> <20170501161130.4302156b@gapa-Lenovo-IdeaPad-Y580> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170501161130.4302156b@gapa-Lenovo-IdeaPad-Y580> X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 01, 2017 at 04:11:30PM +0200, gapalinux wrote: > On Mon, 1 May 2017 19:59:44 +1000 > "Tobin C. Harding" wrote: > > > On Sat, Apr 29, 2017 at 07:54:30PM +0200, Cezary Gapinski wrote: > > > Sparse spits out a warnings about __le16 and unsigned short > > > assignment. Change the type of size and event members of struct > > > hostif_hdr to __le16 and correct conversion to the proper cpu type. > > > > > > Signed-off-by: Cezary Gapinski > > > > After discussion on kernelnewbies mailing list and thinking about this > > for a couple of days I am now of the opinion that this patch is > > merge-able. I am probably not fully qualified to say so but no one > > else appears to be super active on this driver. If I am wrong, I'll be > > here to fix it up :) > > > > Reviewed-by: Tobin C. Harding > > > > Good work Cezsary, apologies for the wish-washy replies. I'm learning > > also ;) > > > > Good luck, > > Tobin. > > Hi Tobin, > > nice to know that you also thinking about this fixes. I think that is > just a first step because I noticed much more warning with > big/little-endian issues and perhaps no one else want to touch this. I did up a patch set yesterday that fixes most of the Sparse warnings. It was simply a matter of changing all struct members in ks_hostif.h to be __leXX and adding a few cpu_to_leXX()/leXX_to_cpu() calls. Exactly as you did. I'm going to wait for your patch, and another that is in flight on ks7010, to be merged before I submit it. There will still be a few Sparse warnings that are a little more tricky, so there is still some fun to be had. > I'm also here to help if it is something will be incorrect ;)." Cool > Sorry for my previous messages. Sometimes I forget about crtl+s will > sending my e-mails, so if you received other messages just ignore it. Didn't receive any extra messages :) Cheers, Tobin.