From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbdEAVrY (ORCPT ); Mon, 1 May 2017 17:47:24 -0400 Received: from mail-pg0-f65.google.com ([74.125.83.65]:33798 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753253AbdEAVqa (ORCPT ); Mon, 1 May 2017 17:46:30 -0400 Date: Mon, 1 May 2017 14:46:27 -0700 From: Brian Norris To: Christophe Leroy Cc: Boris Brezillon , Richard Weinberger , David Woodhouse , Marek Vasut , Cyrille Pitchen , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: nand: gpio: make nCE GPIO optional Message-ID: <20170501214627.GB140640@google.com> References: <20170210140110.87903682E7@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170210140110.87903682E7@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 03:01:10PM +0100, Christophe Leroy wrote: > On some hardware, the nCE signal is wired to the ChipSelect associated > to bus address of the NAND, so it is automatically driven during the > memory access and it is not managed by a GPIO. > > Signed-off-by: Christophe Leroy Not really a problem with this patch exactly, but FYI you're only making this optional for the non-DT case. For device tree, this is kinda hard to do, since the current binding suggests we retrieve the GPIOs based on index position, not by name. So if you leave one off...I guess we well just be off-by-1 on the indeces until we hit a non-optional one...which I guess is "CLE". If we wanted this to work for DT, we'd need to extend this driver (and binding doc) to support requesting GPIOs by name. Brian