From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields
Date: Tue, 2 May 2017 08:41:47 +0200 [thread overview]
Message-ID: <20170502064147.GB23708@krava> (raw)
In-Reply-To: <20170501194746.10296-1-andi@firstfloor.org>
On Mon, May 01, 2017 at 12:47:46PM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> With perf script it is common that we just want to add or remove a field.
> Currently this requires figuring out the long list of default fields and
> specifying them first, and then adding/removing the new field.
>
> This patch adds a new + - syntax to merely add or remove fields,
> that allows more succint and clearer command lines
>
> For example to remove the comm field from PMU samples:
>
> Previously
>
> perf script -F pid,cpu,time,event,sym,ip,dso,period
> 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
>
> with the new syntax
>
> perf script -F -comm
> 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms])
I haven't checked deeply yet, but I'm getting different pids
with the new syntax, perhaps some mixing with tids column?
0 [002] 42615.004240: 2172 cycles: ffffffff86060c66 native_write_msr ([kernel.kallsyms])
0 [002] 42615.004242: 19857 cycles: ffffffff860abee0 irq_exit ([kernel.kallsyms])
0 [002] 42615.004250: 412618 cycles: ffffffff860d1429 ttwu_do_wakeup ([kernel.kallsyms])
- 1798 [001] 42615.008219: 46557 cycles: ffffffff860dc718 update_blocked_averages ([kernel.kallsyms])
- 1798 [001] 42615.008239: 46557 cycles: 7f313dff0684 [unknown] (/usr/lib64/firefox/libxul.so)
- 1798 [001] 42615.008258: 112387 cycles: 7f313e32c71a [unknown] (/usr/lib64/firefox/libxul.so)
+ 1861 [001] 42615.008219: 46557 cycles: ffffffff860dc718 update_blocked_averages ([kernel.kallsyms])
+ 1861 [001] 42615.008239: 46557 cycles: 7f313dff0684 [unknown] (/usr/lib64/firefox/libxul.so)
+ 1861 [001] 42615.008258: 112387 cycles: 7f313e32c71a [unknown] (/usr/lib64/firefox/libxul.so)
1687 [002] 42615.008268: 1711528 cycles: ffffffffc01e74c7 i915_gem_set_domain_ioctl ([i915])
- 1798 [001] 42615.008303: 281652 cycles: ffffffff860dc169 account_entity_dequeue ([kernel.kallsyms])
+ 1861 [001] 42615.008303: 281652 cycles: ffffffff860dc169 account_entity_dequeue ([kernel.kallsyms])
1798 [001] 42615.008440: 442473 cycles: 7f3147c6935b g_slice_free1 (/usr/lib64/libglib-2.0.so.0.5000.3)
- 1935 [001] 42615.009462: 487718 cycles: ffffffff860f25bc cpuacct_charge ([kernel.kallsyms])
- 1935 [002] 42615.009955: 1711528 cycles: 7fa2a2ac748f [unknown] (/usr/lib64/firefox/libmozavcodec.so)
- 1935 [001] 42615.009989: 441676 cycles: 559627e901da [unknown] (/usr/lib64/firefox/firefox)
- 1935 [000] 42615.010233: 79099 cycles: 7fa2c2a11fa9 [unknown] (/usr/lib64/firefox/libxul.so)
+24128 [001] 42615.009462: 487718 cycles: ffffffff860f25bc cpuacct_charge ([kernel.kallsyms])
+24182 [002] 42615.009955: 1711528 cycles: 7fa2a2ac748f [unknown] (/usr/lib64/firefox/libmozavcodec.so)
+24181 [001] 42615.009989: 441676 cycles: 559627e901da [unknown] (/usr/lib64/firefox/firefox)
+24112 [000] 42615.010233: 79099 cycles: 7fa2c2a11fa9 [unknown] (/usr/lib64/firefox/libxul.so)
thanks,
jirka
next prev parent reply other threads:[~2017-05-02 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 19:47 [PATCH] perf, tools, script: Allow adding and removing fields Andi Kleen
2017-05-02 6:41 ` Jiri Olsa [this message]
2017-05-04 22:26 ` Andi Kleen
2017-05-05 7:57 ` Jiri Olsa
2017-05-05 19:43 ` Andi Kleen
2017-05-07 14:08 ` Jiri Olsa
-- strict thread matches above, loose matches on Subject: below --
2017-05-08 16:21 Andi Kleen
2017-05-09 12:18 ` Jiri Olsa
2017-05-09 12:29 ` Andi Kleen
2017-05-09 13:45 ` Jiri Olsa
2017-05-09 14:34 ` Andi Kleen
2017-05-09 14:36 Andi Kleen
2017-05-09 17:05 ` Jiri Olsa
2017-06-02 15:48 Andi Kleen
2017-06-08 12:59 ` Milian Wolff
2017-06-09 2:52 ` Andi Kleen
2017-06-09 9:13 ` Milian Wolff
2017-06-11 19:06 ` Andi Kleen
2017-06-08 14:34 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502064147.GB23708@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox