From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751302AbdEBJDt convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Tue, 2 May 2017 05:03:49 -0400
Received: from mail.free-electrons.com ([62.4.15.54]:49452 "EHLO
        mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750983AbdEBJDq (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 May 2017 05:03:46 -0400
Date: Tue, 2 May 2017 11:03:34 +0200
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: Brian Norris <computersforpeace@gmail.com>,
        Richard Weinberger <richard@nod.at>,
        David Woodhouse <dwmw2@infradead.org>,
        Marek Vasut <marek.vasut@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: gpio: make nCE GPIO optional
Message-ID: <20170502110334.33f1a3b8@bbrezillon>
In-Reply-To: <e35093cc-f5f0-f561-10cb-40d5a141e819@c-s.fr>
References: <20170210140110.87903682E7@localhost.localdomain>
        <20170501214627.GB140640@google.com>
        <e35093cc-f5f0-f561-10cb-40d5a141e819@c-s.fr>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2 May 2017 07:47:40 +0200
Christophe LEROY <christophe.leroy@c-s.fr> wrote:

> Le 01/05/2017 à 23:46, Brian Norris a écrit :
> > On Fri, Feb 10, 2017 at 03:01:10PM +0100, Christophe Leroy wrote:  
> >> On some hardware, the nCE signal is wired to the ChipSelect associated
> >> to bus address of the NAND, so it is automatically driven during the
> >> memory access and it is not managed by a GPIO.
> >>
> >> Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>  
> >
> > Not really a problem with this patch exactly, but FYI you're only making
> > this optional for the non-DT case. For device tree, this is kinda hard
> > to do, since the current binding suggests we retrieve the GPIOs based on
> > index position, not by name. So if you leave one off...I guess we well
> > just be off-by-1 on the indeces until we hit a non-optional one...which
> > I guess is "CLE".
> >
> > If we wanted this to work for DT, we'd need to extend this driver (and
> > binding doc) to support requesting GPIOs by name.
> >  
> 
> It works for me with devicetree.
> 
> I have the following definition in my DT:
> 
> 		nand@1,0 {
> 			compatible = "gpio-control-nand";
> 			reg = <1 0x0 0x01>;
> 			#address-cells = <1>;
> 			#size-cells = <1>;
> 			gpios = <&qe_pio_c 24 1 	// RDY
> 				 0			// nCE
> 				 &qe_pio_c 26 1		// ALE
> 				 &qe_pio_c 25 1		// CLE
> 				 0>;			// nwp  
> 		};
> 

Yep, it's perfectly fine to have 'empty' gpio entries (entries with
phandle set to 0/NULL), we're using this trick in the atmel_nand
driver as well.