From: Wei Yang <richard.weiyang@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Wei Yang <richard.weiyang@gmail.com>,
kirill@shutemov.name, bp@alien8.de, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, tj@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed
Date: Tue, 2 May 2017 21:06:07 +0800 [thread overview]
Message-ID: <20170502130607.GA5731@WeideMacBook-Pro.local> (raw)
In-Reply-To: <alpine.DEB.2.10.1705011436480.137835@chino.kir.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 1158 bytes --]
On Mon, May 01, 2017 at 02:37:06PM -0700, David Rientjes wrote:
>On Tue, 11 Apr 2017, Wei Yang wrote:
>
>> On Mon, Apr 10, 2017 at 05:26:03PM -0700, David Rientjes wrote:
>> >On Tue, 11 Apr 2017, Wei Yang wrote:
>> >
>> >> According to current code path, numa_nodes_parsed is already setup when
>> >> numa_emucation() is called.
>> >>
>> >> x86_numa_init()
>> >> numa_init()
>> >> init_func()
>> >>
>> >> numa_emulation()
>> >>
>> >> numa_register_memblks()
>> >>
>> >
>> >s/numa_emucation/numa_emulation/, but I think everything above should just
>> >be reworded to say the following since it establishes the dependency:
>> >
>> >numa_init() has already called init_func(), which is responsible for
>> >setting numa_nodes_parsed, so use this nodemask instead of re-finding it
>> >when calling numa_emulation().
>> >
>>
>> Yep, thanks.
>>
>> Looks your change log is better :-)
>>
>
>Thanks! Would it be possible to refresh the series and repost for the x86
>maintainers?
Sure, I have sent out V2 with changes from your comments.
Thanks~
--
Wei Yang
Help you, Help me
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2017-05-02 13:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 16:56 [PATCH 0/3] Refine numa_emulation Wei Yang
2017-04-10 16:56 ` [PATCH 1/3] x86/numa_emulation: fix potential memory leak Wei Yang
2017-04-11 0:16 ` David Rientjes
2017-04-10 16:56 ` [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly from numa_nodes_parsed Wei Yang
2017-04-11 0:26 ` David Rientjes
2017-04-11 1:42 ` Wei Yang
2017-05-01 21:37 ` David Rientjes
2017-05-02 13:06 ` Wei Yang [this message]
2017-04-10 16:56 ` [PATCH 3/3] x86/numa_emulation: restructures numa_nodes_parsed from emulated nodes Wei Yang
2017-04-11 0:36 ` David Rientjes
2017-04-11 1:44 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170502130607.GA5731@WeideMacBook-Pro.local \
--to=richard.weiyang@gmail.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox