From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751489AbdEBNGM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 2 May 2017 09:06:12 -0400
Received: from mail-pg0-f66.google.com ([74.125.83.66]:35544 "EHLO
        mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751344AbdEBNGK (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 May 2017 09:06:10 -0400
Date: Tue, 2 May 2017 21:06:07 +0800
From: Wei Yang <richard.weiyang@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: Wei Yang <richard.weiyang@gmail.com>, kirill@shutemov.name,
        bp@alien8.de, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
        tj@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] x86/numa_emulation: assign physnode_mask directly
 from numa_nodes_parsed
Message-ID: <20170502130607.GA5731@WeideMacBook-Pro.local>
Reply-To: Wei Yang <richard.weiyang@gmail.com>
References: <20170410165652.50250-1-richard.weiyang@gmail.com>
 <20170410165652.50250-3-richard.weiyang@gmail.com>
 <alpine.DEB.2.10.1704101722540.116868@chino.kir.corp.google.com>
 <20170411014223.GA35630@WeideMacBook-Pro.local>
 <alpine.DEB.2.10.1705011436480.137835@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ew6BAiZeqk4r7MaW"
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1705011436480.137835@chino.kir.corp.google.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--ew6BAiZeqk4r7MaW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 01, 2017 at 02:37:06PM -0700, David Rientjes wrote:
>On Tue, 11 Apr 2017, Wei Yang wrote:
>
>> On Mon, Apr 10, 2017 at 05:26:03PM -0700, David Rientjes wrote:
>> >On Tue, 11 Apr 2017, Wei Yang wrote:
>> >
>> >> According to current code path, numa_nodes_parsed is already setup wh=
en
>> >> numa_emucation() is called.
>> >>=20
>> >>     x86_numa_init()
>> >>         numa_init()
>> >> 	    init_func()
>> >>=20
>> >> 	    numa_emulation()
>> >>=20
>> >>             numa_register_memblks()
>> >>
>> >
>> >s/numa_emucation/numa_emulation/, but I think everything above should j=
ust=20
>> >be reworded to say the following since it establishes the dependency:
>> >
>> >numa_init() has already called init_func(), which is responsible for=20
>> >setting numa_nodes_parsed, so use this nodemask instead of re-finding i=
t=20
>> >when calling numa_emulation().
>> >
>>=20
>> Yep, thanks.
>>=20
>> Looks your change log is better :-)
>>=20
>
>Thanks!  Would it be possible to refresh the series and repost for the x86=
=20
>maintainers?

Sure, I have sent out V2 with changes from your comments.

Thanks~

--=20
Wei Yang
Help you, Help me

--ew6BAiZeqk4r7MaW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJZCIQ/AAoJEKcLNpZP5cTdDKgP/jLs80suP1FJR2Dd0kREev6s
plCLytzNfM+R1Az/BA1tUZflD44c1kjof4J3f4f2Vzx+1Cc01suzASxPIeEZVaQG
YJcawSq3026q82D6IQpRhJdEudKzXCcNZ+Lrcoag0VqBszBXr2cX5R9rGFTb9NcA
nz82T6yQp4OlrFm8z3rscSVpeNyGQfmQWVfzH75G/yPGhWIEWkVibuvaMy6q5GCY
pyx2Csv4sP9ErAFWsOKPZmUC+IbcNm9UUjmhD5hNqI39gvqQqGM2JX3Wju1htH6c
VIjfH7IILF6l0OCBAvEXfk9TtWeMQaVaboXUdxt3kI6GmfAbG+GA8DIWbWNEF9CS
CAQIMmKiW2MPKyMVBCif7qt1ZSZszC6bqE49R9knHWbKl6E1Ch05SScrpCHlDB8v
wUB8kE/BPNzdRg+Wwkk+9PLwmvl0BBLstkg76FRSaUvbsu9TmU4/bcj/bMf+m3gp
rflgv/fxz7foLZbQE3Od7blWHFJ4OCSV6PDuoSPaEBkI5Q0tekdYY4YE7Grf7AWQ
tExfhaaF/5+4YqfRTcsfi8nPsuYrfj9drbpMKOhpUFxUj8EoWhPlYiTbMxj8z043
Sk5nLvJIg9GI73qtjzMAEXA8yga2n6yrLUoVc2HMkV9ycbFUl6Vn5nneSXK5jfT9
VykLg54l6zzPIMLHPJR8
=ZSlD
-----END PGP SIGNATURE-----

--ew6BAiZeqk4r7MaW--