Re: hexagon: Use raw_copy_to_user

Guenter Roeck
2017-06-02T13:03:57Z

ping ....

On Tue, May 02, 2017 at 08:52:48PM -0700, Guenter Roeck wrote:
> Commit ac4691fac8ad ("hexagon: switch to RAW_COPY_USER") replaced
> __copy_to_user_hexagon() with raw_copy_to_user(), but did not catch
> all callers, resulting in the following build error.
>
> arch/hexagon/mm/uaccess.c: In function '__clear_user_hexagon':
> arch/hexagon/mm/uaccess.c:40:3: error:
> implicit declaration of function '__copy_to_user_hexagon'
>
> Fixes: ac4691fac8ad ("hexagon: switch to RAW_COPY_USER")
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> Acked-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> arch/hexagon/mm/uaccess.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/hexagon/mm/uaccess.c b/arch/hexagon/mm/uaccess.c
> index ec90afdb3ad0..c599eb126c9e 100644
> --- a/arch/hexagon/mm/uaccess.c
> +++ b/arch/hexagon/mm/uaccess.c
> @@ -37,15 +37,14 @@ __kernel_size_t __clear_user_hexagon(void __user *dest, unsigned long count)
> long uncleared;
>
> while (count > PAGE_SIZE) {
> - uncleared = __copy_to_user_hexagon(dest, &empty_zero_page,
> - PAGE_SIZE);
> + uncleared = raw_copy_to_user(dest, &empty_zero_page, PAGE_SIZE);
> if (uncleared)
> return count - (PAGE_SIZE - uncleared);
> count -= PAGE_SIZE;
> dest += PAGE_SIZE;
> }
> if (count)
> - count = __copy_to_user_hexagon(dest, &empty_zero_page, count);
> + count = raw_copy_to_user(dest, &empty_zero_page, count);
>
> return count;
> }