From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752072AbdECHHr (ORCPT ); Wed, 3 May 2017 03:07:47 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:39776 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbdECHHk (ORCPT ); Wed, 3 May 2017 03:07:40 -0400 Date: Wed, 3 May 2017 08:07:26 +0100 From: Al Viro To: Ding Tianhong Cc: David Miller , pabeni@redhat.com, edumazet@google.com, hannes@stressinduktion.org, "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , LinuxArm , "weiyongjun (A)" Subject: Re: [PATCH v3] iov_iter: don't revert iov buffer if csum error Message-ID: <20170503070726.GG29622@ZenIV.linux.org.uk> References: <12d4d81f-40c7-c83d-11d6-290acc084695@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12d4d81f-40c7-c83d-11d6-290acc084695@huawei.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 03:02:32PM +0800, Ding Tianhong wrote: > The patch 327868212381 (make skb_copy_datagram_msg() et.al. preserve > ->msg_iter on error) will revert the iov buffer if copy to iter > failed, but it didn't copy any datagram if the skb_checksum_complete > error, so no need to revert any data at this place. See a6a5993243550b09f620941dea741b7421fdf79c in mainline...