From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751860AbdECMjA (ORCPT ); Wed, 3 May 2017 08:39:00 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:51864 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750966AbdECMiz (ORCPT ); Wed, 3 May 2017 08:38:55 -0400 Date: Wed, 3 May 2017 14:38:32 +0200 From: Florian Westphal To: Geert Uytterhoeven Cc: "David S . Miller" , Florian Westphal , Pablo Neira Ayuso , Jozsef Kadlecsik , Arnd Bergmann , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure Message-ID: <20170503123832.GB27809@breakpoint.cc> References: <1493813923-5441-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493813923-5441-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Geert Uytterhoeven wrote: > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > build will fail with: > > net/built-in.o: In function `nf_conntrack_init_start': > (.text+0x9baf6): undefined reference to `__compiletime_assert_1893' > > or > > ERROR: "__compiletime_assert_1893" [net/netfilter/nf_conntrack.ko] undefined! > > Fix this by forcing inlining of total_extension_size(). Sorry about that, thanks for the fix Geert. Acked-by: Florian Westphal