From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752798AbdECN5u (ORCPT <rfc822;w@1wt.eu>);
        Wed, 3 May 2017 09:57:50 -0400
Received: from mail.kernel.org ([198.145.29.136]:43400 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751998AbdECN5n (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 3 May 2017 09:57:43 -0400
Date: Wed, 3 May 2017 21:57:18 +0800
From: Shawn Guo <shawnguo@kernel.org>
To: Marek Vasut <marex@denx.de>
Cc: Leonard Crestez <leonard.crestez@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Sascha Hauer <kernel@pengutronix.de>, Peter Chen <Peter.Chen@nxp.com>,
        Anson Huang <Anson.Huang@nxp.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Fabio Estevam <fabio.estevam@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Christoph Fritz <chf.fritz@googlemail.com>
Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override
Message-ID: <20170503135715.GG18578@dragon>
References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com>
 <CAOMZO5BsgXRfgZ0hszk2Vgo2keVDHH1BLbJTbW+awMS2cBoNow@mail.gmail.com>
 <CAOMZO5CKUsEr1yf5RrsPLipNtLC_6sK0dPjT2M-eN-uo8hEbrQ@mail.gmail.com>
 <1493141004.3557.8.camel@nxp.com>
 <f3bbd20c-2132-1121-1044-ba00dba302d6@denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f3bbd20c-2132-1121-1044-ba00dba302d6@denx.de>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Apr 25, 2017 at 07:28:06PM +0200, Marek Vasut wrote:
> On 04/25/2017 07:23 PM, Leonard Crestez wrote:
> > Anyway, that version also sets the supply for reg_arm and reg_soc. It
> > is not necessary for fixing the crash I'm seeing but is good because it
> > will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix
> > 1375mv. I tested Marek's patch and it works fine on my rev B board
> > (which otherwise fails to boot upstream).
> 
> Oh that's nice , thanks ! I don't have SDB and I hacked it up after a
> brief discussion with Fabio without even compile-testing it, thus RFC.
> Glad to hear it works and thanks for testing it ! Can you add a formal
> Tested-by please ?

Hi Marek,

Thanks for your patch.  But I prefer Leonard's version because: 1) it
has a better commit log; 2) it sticks to one-patch-does-one-thing
policy.

But I'm going to wait for a while to get Peter's comment discussed,
before I actually apply Leonard's patch.

Shawn