From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752582AbdECOLC (ORCPT ); Wed, 3 May 2017 10:11:02 -0400 Received: from mail.us.es ([193.147.175.20]:33632 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752678AbdECOKz (ORCPT ); Wed, 3 May 2017 10:10:55 -0400 Date: Wed, 3 May 2017 16:10:44 +0200 From: Pablo Neira Ayuso To: David Miller Cc: geert@linux-m68k.org, fw@strlen.de, kadlec@blackhole.kfki.hu, arnd@arndb.de, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: conntrack: Force inlining of build check to prevent build failure Message-ID: <20170503141044.GA1308@salvia> References: <1493813923-5441-1-git-send-email-geert@linux-m68k.org> <20170503.095516.84626203716316173.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170503.095516.84626203716316173.davem@davemloft.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 09:55:16AM -0400, David Miller wrote: > From: Geert Uytterhoeven > Date: Wed, 3 May 2017 14:18:43 +0200 > > > If gcc (e.g. 4.1.2) decides not to inline total_extension_size(), the > > build will fail with: > > > > net/built-in.o: In function `nf_conntrack_init_start': > > (.text+0x9baf6): undefined reference to `__compiletime_assert_1893' > > > > or > > > > ERROR: "__compiletime_assert_1893" [net/netfilter/nf_conntrack.ko] undefined! > > > > Fix this by forcing inlining of total_extension_size(). > > > > Fixes: b3a5db109e0670d6 ("netfilter: conntrack: use u8 for extension sizes again") > > Signed-off-by: Geert Uytterhoeven > > Pablo, I'm going to apply this directly to my tree to fix this build > failure, I hope you don't mind. Acked-by: Pablo Neira Ayuso