From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753944AbdECOlg (ORCPT ); Wed, 3 May 2017 10:41:36 -0400 Received: from mail.kernel.org ([198.145.29.136]:50820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753893AbdECOl2 (ORCPT ); Wed, 3 May 2017 10:41:28 -0400 Date: Wed, 3 May 2017 22:41:01 +0800 From: Shawn Guo To: Marek Vasut Cc: Leonard Crestez , Fabio Estevam , Sascha Hauer , Peter Chen , Anson Huang , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , linux-kernel , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Christoph Fritz Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override Message-ID: <20170503144059.GL18578@dragon> References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com> <1493141004.3557.8.camel@nxp.com> <20170503135715.GG18578@dragon> <76e22a7e-590f-00ee-04f8-87604303eaad@denx.de> <0f84e2ee-1ea1-acf8-8368-3fc848d33e23@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0f84e2ee-1ea1-acf8-8368-3fc848d33e23@denx.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 03, 2017 at 04:32:06PM +0200, Marek Vasut wrote: > On 05/03/2017 04:26 PM, Marek Vasut wrote: > > On 05/03/2017 03:57 PM, Shawn Guo wrote: > >> On Tue, Apr 25, 2017 at 07:28:06PM +0200, Marek Vasut wrote: > >>> On 04/25/2017 07:23 PM, Leonard Crestez wrote: > >>>> Anyway, that version also sets the supply for reg_arm and reg_soc. It > >>>> is not necessary for fixing the crash I'm seeing but is good because it > >>>> will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix > >>>> 1375mv. I tested Marek's patch and it works fine on my rev B board > >>>> (which otherwise fails to boot upstream). > >>> > >>> Oh that's nice , thanks ! I don't have SDB and I hacked it up after a > >>> brief discussion with Fabio without even compile-testing it, thus RFC. > >>> Glad to hear it works and thanks for testing it ! Can you add a formal > >>> Tested-by please ? > >> > >> Hi Marek, > > > > Hi Shawn, > > > >> Thanks for your patch. But I prefer Leonard's version because: 1) it > >> has a better commit log; 2) it sticks to one-patch-does-one-thing > >> policy. > > > > Well I'd prefer this patch because > > 1) It has T-B > > Correction, two TBs [1] > > [1] https://patchwork.kernel.org/patch/9698749/ That doesn't mean Leonard's patch hasn't been tested by anyone. > > 2) It actually fixes a problem with the voltage rails such that the DVFS > > works without leaving the system in unstable or dead state. You do > > need the second part of my patch if you drop the OPP hackery, without > > it the power framework cannot correctly configure the core voltages, > > so the patch from Leonard makes things worse. If that's true, I will change my mind. Shawn