From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753873AbdECRRp (ORCPT ); Wed, 3 May 2017 13:17:45 -0400 Received: from gateway21.websitewelcome.com ([192.185.46.113]:32600 "EHLO gateway21.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753729AbdECRRi (ORCPT ); Wed, 3 May 2017 13:17:38 -0400 Date: Wed, 3 May 2017 12:17:30 -0500 From: "Gustavo A. R. Silva" To: "David S. Miller" , Jesper Dangaard Brouer , Eric Dumazet Cc: netdev@vager.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: [PATCH] net: core: remove unnecessary code Message-ID: <20170503171730.GA14179@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 177.237.170.200 X-Exim-ID: 1d5xu7-0007m6-Te X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (embeddedgus) [177.237.170.200]:18176 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 5 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The name of an array used by itself will always return the array's address. So this test will always evaluate as true. Addresses-Coverity-ID: 115325 Signed-off-by: Gustavo A. R. Silva --- net/core/netpoll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/core/netpoll.c b/net/core/netpoll.c index 9424673..27ce3b1 100644 --- a/net/core/netpoll.c +++ b/net/core/netpoll.c @@ -657,13 +657,13 @@ int netpoll_setup(struct netpoll *np) { struct net_device *ndev = NULL; struct in_device *in_dev; + struct net *net; int err; rtnl_lock(); - if (np->dev_name) { - struct net *net = current->nsproxy->net_ns; - ndev = __dev_get_by_name(net, np->dev_name); - } + net = current->nsproxy->net_ns; + ndev = __dev_get_by_name(net, np->dev_name); + if (!ndev) { np_err(np, "%s doesn't exist, aborting\n", np->dev_name); err = -ENODEV; -- 2.5.0