From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753779AbdECREk convert rfc822-to-8bit (ORCPT ); Wed, 3 May 2017 13:04:40 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44043 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752331AbdECREc (ORCPT ); Wed, 3 May 2017 13:04:32 -0400 Date: Wed, 3 May 2017 19:04:24 +0200 From: Cornelia Huck To: Radim =?UTF-8?B?S3LEjW3DocWZ?= Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Christoffer Dall , Andrew Jones , Marc Zyngier , Paolo Bonzini , Christian Borntraeger , James Hogan , Paul Mackerras Subject: Re: [PATCH v3] KVM: remove #ifndef CONFIG_S390 around kvm_vcpu_wake_up In-Reply-To: <20170503161634.6056-1-rkrcmar@redhat.com> References: <20170426203227.12321-4-rkrcmar@redhat.com> <20170503161634.6056-1-rkrcmar@redhat.com> Organization: IBM Deutschland Research & Development GmbH Vorsitzende des Aufsichtsrats: Martina Koederitz =?UTF-8?B?R2VzY2jDpGZ0c2bDvGhydW5nOg==?= Dirk Wittkopp Sitz der Gesellschaft: =?UTF-8?B?QsO2Ymxpbmdlbg==?= Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-TM-AS-GCONF: 00 x-cbid: 17050317-0016-0000-0000-00000490A5DC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050317-0017-0000-0000-00002781729F Message-Id: <20170503190424.4f4e62db.cornelia.huck@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-03_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705030309 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 3 May 2017 18:16:34 +0200 Radim Krčmář wrote: > The #ifndef was protecting a missing halt_wakeup stat, but that is no > longer necessary. The #ifndef around kvm_vcpu_kick is still necessary > as s390 does not export smp_send_reschedule. It feels like smp_send_reschedule() should be exported everywhere if kvm wants to use it... but this certainly works as well. Acked-by: Cornelia Huck > > Signed-off-by: Radim Krčmář > --- > v3: kept kvm_vcpu_kick() under the #ifndef and compile tested with kvm > configured as module too ... > > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index 357e67cba32e..7112889e5e1a 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -2195,7 +2195,6 @@ void kvm_vcpu_block(struct kvm_vcpu *vcpu) > } > EXPORT_SYMBOL_GPL(kvm_vcpu_block); > > -#ifndef CONFIG_S390 > void kvm_vcpu_wake_up(struct kvm_vcpu *vcpu) > { > struct swait_queue_head *wqp; > @@ -2209,6 +2208,7 @@ void kvm_vcpu_wake_up(struct kvm_vcpu *vcpu) > } > EXPORT_SYMBOL_GPL(kvm_vcpu_wake_up); > > +#ifndef CONFIG_S390 > /* > * Kick a sleeping VCPU, or a guest VCPU in guest mode, into host kernel mode. > */