From: Shawn Guo <shawnguo@kernel.org>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Gary Bisson <gary.bisson@boundarydevices.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible
Date: Thu, 4 May 2017 21:18:07 +0800 [thread overview]
Message-ID: <20170504131806.GQ18578@dragon> (raw)
In-Reply-To: <20170503221620.k3gf3s7lramlgfyf@piout.net>
On Thu, May 04, 2017 at 12:16:20AM +0200, Alexandre Belloni wrote:
> On 03/05/2017 at 16:50:12 +0800, Shawn Guo wrote:
> > On Wed, Apr 19, 2017 at 10:22:02PM +0200, Alexandre Belloni wrote:
> > > The rv4162 vendor is microcrystal, not ST.
> > >
> > > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> > > ---
> > > arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > index bad3c9f9eeac..b63134e3b51a 100644
> > > --- a/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > +++ b/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi
> > > @@ -408,7 +408,7 @@
> > > };
> > >
> > > rtc: rtc@68 {
> > > - compatible = "st,rv4162";
> > > + compatible = "microcrystal,rv4162";
> >
> > The compatible is not documented?
> >
>
> No, it wasn't. Like for many i2c devices, the driver predates DT and
> didn't need any specific code to be used from DT. Basically, the i2c
> core was using the i2c_device_ids to match the DT compatible string.
> This is changing since cabcf4f6be658b2d4bea26dee89d08fdf67d6811.
>
> I'm planning to document all the undocumented ones soon.
I applied all 3 patches. Please remember to document the compatible.
Shawn
prev parent reply other threads:[~2017-05-04 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-19 20:22 [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: fix rv4162 compatible Alexandre Belloni
2017-04-19 20:22 ` [PATCH 2/3] ARM: dts: imx6qdl-nitrogen6_som2: " Alexandre Belloni
2017-04-20 9:08 ` Gary Bisson
2017-04-19 20:22 ` [PATCH 3/3] ARM: dts: imx7d-nitrogen7: " Alexandre Belloni
2017-04-20 9:09 ` Gary Bisson
2017-04-20 9:08 ` [PATCH 1/3] ARM: dts: imx6qdl-nitrogen6_max: " Gary Bisson
2017-05-03 8:50 ` Shawn Guo
2017-05-03 22:14 ` Fabio Estevam
2017-05-03 22:27 ` Alexandre Belloni
2017-05-03 22:16 ` Alexandre Belloni
2017-05-04 13:18 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504131806.GQ18578@dragon \
--to=shawnguo@kernel.org \
--cc=alexandre.belloni@free-electrons.com \
--cc=fabio.estevam@nxp.com \
--cc=gary.bisson@boundarydevices.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox