From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754176AbdEDNcc (ORCPT ); Thu, 4 May 2017 09:32:32 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:32823 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565AbdEDNc0 (ORCPT ); Thu, 4 May 2017 09:32:26 -0400 From: Daniel Micay To: Kees Cook , Arjan van Ven , Ingo Molnar , kernel-hardening@lists.openwall.com, LKML Cc: Daniel Micay , stable@vger.kernel.org Subject: [PATCH] use get_random_long for the per-task stack canary Date: Thu, 4 May 2017 09:32:09 -0400 Message-Id: <20170504133209.3053-1-danielmicay@gmail.com> X-Mailer: git-send-email 2.12.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The stack canary is an unsigned long and should be fully initialized to random data rather than only 32 bits of random data. Cc: stable@vger.kernel.org Signed-off-by: Daniel Micay --- kernel/fork.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/fork.c b/kernel/fork.c index 56d85fd81411..ff84ff82f56a 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -537,7 +537,7 @@ static struct task_struct *dup_task_struct(struct task_struct *orig, int node) set_task_stack_end_magic(tsk); #ifdef CONFIG_CC_STACKPROTECTOR - tsk->stack_canary = get_random_int(); + tsk->stack_canary = get_random_long(); #endif /* -- 2.12.2