From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbdEDOyp (ORCPT ); Thu, 4 May 2017 10:54:45 -0400 Received: from mail.kernel.org ([198.145.29.136]:56936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752718AbdEDOxq (ORCPT ); Thu, 4 May 2017 10:53:46 -0400 Date: Thu, 4 May 2017 11:53:39 -0300 From: Arnaldo Carvalho de Melo To: Milian Wolff Cc: Jin Yao , jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com Subject: Re: [PATCH v1 2/2] perf report: Display titles in left frame of annotate browser Message-ID: <20170504145339.GF7891@kernel.org> References: <1493909895-9668-1-git-send-email-yao.jin@linux.intel.com> <8076707.4PSiRuChLW@milian-kdab2> <20170504131250.GE7891@kernel.org> <2208290.lxVzDrGPAq@milian-kdab2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2208290.lxVzDrGPAq@milian-kdab2> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, May 04, 2017 at 04:04:42PM +0200, Milian Wolff escreveu: > On Thursday, May 4, 2017 3:12:50 PM CEST Arnaldo Carvalho de Melo wrote: > > Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu: > > > On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote: > > > > This patch adds the titles "Percent", "IPC" and "Cycle" > > > > on columns. > > > > > > > > Percnt IPC Cycle │ > > > > > > > > │25 __attribute__((noinline)) > > > > │26 int compute_flag() > > > > │27 { > > > > > > > > 22.80 1.20 │ sub $0x8,%rsp > > > > > > > > │25 int i; > > > > │ > > > > │27 i = rand() % 2; > > > > > > > > 22.78 1.20 1 │ → callq rand@plt > > > > > > > > The titles are displayed at row 0 of annotate browser if row 0 > > > > doesn't have values of percent, ipc and cycle. > > > > > > Functionality wise a really good improvement - thanks! But personally I > > > find the abbreviation of one character (i.e. "Percnt" instead of > > > "Percent") not so nice. If space really is an issue here, use "%"? > > > > Ok, will make it 'Percent' as we have space for that, and will add > > Acked-by: Millian, ok? > > Just one L, but otherwise yes :) Sure, sorry about that, c'n'pasted from a message from you, so should be all well. > > > Also note though that it's unclear what this percentage actually is. I > > > guess it's a sample percentage? Maybe a header should be added that > > > explains these values to newbies. I bet many people won't even know what > > > IPC is either. > > Perhaps we could have some help files, then when the user presses 'h' > > one of the lines would be: > > > > h Report explanation (columns, etc) > > Yeah I think that would be a good addition for the future. :-) - Arnaldo