From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754989AbdEDPe4 (ORCPT ); Thu, 4 May 2017 11:34:56 -0400 Received: from quartz.orcorp.ca ([184.70.90.242]:37443 "EHLO quartz.orcorp.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754415AbdEDPeU (ORCPT ); Thu, 4 May 2017 11:34:20 -0400 Date: Thu, 4 May 2017 09:34:16 -0600 From: Jason Gunthorpe To: Stefan Berger Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, jarkko.sakkinen@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] tpm: vtpm_proxy: Implement new ioctl to get supported flags Message-ID: <20170504153416.GA15930@obsidianresearch.com> References: <1493909787-1848-1-git-send-email-stefanb@linux.vnet.ibm.com> <1493909787-1848-2-git-send-email-stefanb@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493909787-1848-2-git-send-email-stefanb@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Broken-Reverse-DNS: no host name found for IP address 10.0.0.156 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 04, 2017 at 10:56:25AM -0400, Stefan Berger wrote: > Implement VTPM_PROXY_IOC_GET_SUPT_FLAGS ioctl to get the bitmask > of flags that the vtpm_proxy driver supports in the > VTPM_PROXY_IOC_NEW_DEV ioctl. This helps user space in deciding > which flags to set in that ioctl. you might be better off just having a VTPM_PROXY_IO_ENABLE_FEATURE .feature = LOCALITY If that fails then the feature is not supported, no real need for the query in that case. Not sure about Jarkko's point on request/release locality.. Is there a scenario where the emulator should fail the request locality? Jason