From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751808AbdEDVAL (ORCPT ); Thu, 4 May 2017 17:00:11 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42451 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751119AbdEDVAK (ORCPT ); Thu, 4 May 2017 17:00:10 -0400 Date: Thu, 4 May 2017 14:00:05 -0700 From: "Paul E. McKenney" To: kbuild test robot Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org Subject: Re: [rcu:dev.2017.05.04a 89/89] include/linux/rcupdate.h:273:10: note: in expansion of macro 'preemptible' Reply-To: paulmck@linux.vnet.ibm.com References: <201705050427.Z6yONyBg%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201705050427.Z6yONyBg%fengguang.wu@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17050421-0044-0000-0000-00000321F2D2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007022; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000209; SDB=6.00856259; UDB=6.00423885; IPR=6.00635459; BA=6.00005326; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015308; XFM=3.00000014; UTC=2017-05-04 21:00:07 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050421-0045-0000-0000-0000074FFD12 Message-Id: <20170504210005.GC3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-05-04_13:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705040300 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 04:12:31AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2017.05.04a > head: f506321acd3999cabe6905e8b3b1cd50c074741d > commit: f506321acd3999cabe6905e8b3b1cd50c074741d [89/89] rcu: Move ktime needs to rcutiny.h and remove ktime.h from rcupdate.h > config: ia64-allmodconfig (attached as .config) > compiler: ia64-linux-gcc (GCC) 6.2.0 > reproduce: > wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout f506321acd3999cabe6905e8b3b1cd50c074741d > # save the attached .config to linux build tree > make.cross ARCH=ia64 > > All warnings (new ones prefixed by >>): I guess that rcupdate.h needs irqflags.h after all... Fixing. Thanx, Paul > warning: (FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && KMEMCHECK && LOCKDEP) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300 || METAG) || ARCH_WANT_FRAME_POINTERS) > warning: (FAULT_INJECTION_STACKTRACE_FILTER && LATENCYTOP && KMEMCHECK && LOCKDEP) selects FRAME_POINTER which has unmet direct dependencies (DEBUG_KERNEL && (CRIS || M68K || FRV || UML || AVR32 || SUPERH || BLACKFIN || MN10300 || METAG) || ARCH_WANT_FRAME_POINTERS) > In file included from include/linux/rcupdate.h:36:0, > from include/linux/rculist.h:10, > from include/linux/sched/signal.h:4, > from arch/ia64/kernel/asm-offsets.c:9: > include/linux/rcupdate.h: In function 'rcu_read_lock_sched_held': > include/linux/preempt.h:185:49: error: implicit declaration of function 'irqs_disabled' [-Werror=implicit-function-declaration] > #define preemptible() (preempt_count() == 0 && !irqs_disabled()) > ^ > >> include/linux/rcupdate.h:273:10: note: in expansion of macro 'preemptible' > return !preemptible(); > ^~~~~~~~~~~ > cc1: some warnings being treated as errors > make[2]: *** [arch/ia64/kernel/asm-offsets.s] Error 1 > make[2]: Target '__build' not remade because of errors. > make[1]: *** [prepare0] Error 2 > make[1]: Target 'prepare' not remade because of errors. > make: *** [sub-make] Error 2 > > vim +/preemptible +273 include/linux/rcupdate.h > > 632ee200 Paul E. McKenney 2010-02-22 257 > d8ab29f8 Paul E. McKenney 2011-10-07 258 # define rcu_lock_acquire(a) do { } while (0) > d8ab29f8 Paul E. McKenney 2011-10-07 259 # define rcu_lock_release(a) do { } while (0) > 632ee200 Paul E. McKenney 2010-02-22 260 > 632ee200 Paul E. McKenney 2010-02-22 261 static inline int rcu_read_lock_held(void) > 632ee200 Paul E. McKenney 2010-02-22 262 { > 632ee200 Paul E. McKenney 2010-02-22 263 return 1; > 632ee200 Paul E. McKenney 2010-02-22 264 } > 632ee200 Paul E. McKenney 2010-02-22 265 > 632ee200 Paul E. McKenney 2010-02-22 266 static inline int rcu_read_lock_bh_held(void) > 632ee200 Paul E. McKenney 2010-02-22 267 { > 632ee200 Paul E. McKenney 2010-02-22 268 return 1; > 632ee200 Paul E. McKenney 2010-02-22 269 } > 632ee200 Paul E. McKenney 2010-02-22 270 > 632ee200 Paul E. McKenney 2010-02-22 271 static inline int rcu_read_lock_sched_held(void) > 632ee200 Paul E. McKenney 2010-02-22 272 { > 293e2421 Boqun Feng 2016-03-23 @273 return !preemptible(); > 632ee200 Paul E. McKenney 2010-02-22 274 } > 632ee200 Paul E. McKenney 2010-02-22 275 #endif /* #else #ifdef CONFIG_DEBUG_LOCK_ALLOC */ > 632ee200 Paul E. McKenney 2010-02-22 276 > 632ee200 Paul E. McKenney 2010-02-22 277 #ifdef CONFIG_PROVE_RCU > 632ee200 Paul E. McKenney 2010-02-22 278 > 4221a991 Tetsuo Handa 2010-06-26 279 /** > f78f5b90 Paul E. McKenney 2015-06-18 280 * RCU_LOCKDEP_WARN - emit lockdep splat if specified condition is met > f78f5b90 Paul E. McKenney 2015-06-18 281 * @c: condition to check > > :::::: The code at line 273 was first introduced by commit > :::::: 293e2421fe25839500207eda123cc4475f8d17b8 rcu: Remove superfluous versions of rcu_read_lock_sched_held() > > :::::: TO: Boqun Feng > :::::: CC: Paul E. McKenney > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation