From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755298AbdEEJCH (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 05:02:07 -0400
Received: from bombadil.infradead.org ([65.50.211.133]:35511 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751116AbdEEJCF (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 05:02:05 -0400
Date: Fri, 5 May 2017 02:02:01 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: Bart Van Assche <Bart.VanAssche@sandisk.com>,
        "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] sd: Ignore sync cache failures when not supported
Message-ID: <20170505090201.GA31209@infradead.org>
References: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1493891010-24258-1-git-send-email-thierry.escande@collabora.com>
User-Agent: Mutt/1.8.0 (2017-02-23)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Normally we'd just pass the scsi_sense_hdr structure in from the
caler if we care about sense data.  Is this something you considered?

Otherwise this looks fine to me.