From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752085AbdEEJUv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 5 May 2017 05:20:51 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:36127 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751116AbdEEJUu (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 5 May 2017 05:20:50 -0400
Date: Fri, 5 May 2017 11:20:46 +0200
From: Ingo Molnar <mingo@kernel.org>
To: xlpang@redhat.com
Cc: linux-kernel@vger.kernel.org, kexec@lists.infradead.org,
        akpm@linux-foundation.org, Eric Biederman <ebiederm@xmission.com>,
        Dave Young <dyoung@redhat.com>, x86@kernel.org,
        Borislav Petkov <bp@alien8.de>, Thomas Gleixner <tglx@linutronix.de>,
        Yinghai Lu <yinghai@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v3 2/2] x86_64/kexec: Use PUD level 1GB page for identity
 mapping if available
Message-ID: <20170505092046.2qu72pdherfxjmec@gmail.com>
References: <1493862171-8799-1-git-send-email-xlpang@redhat.com>
 <1493862171-8799-2-git-send-email-xlpang@redhat.com>
 <20170505065253.s5yv7c2cxgfcf4i3@gmail.com>
 <590C2A96.3090106@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <590C2A96.3090106@redhat.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


* Xunlei Pang <xpang@redhat.com> wrote:

> On 05/05/2017 at 02:52 PM, Ingo Molnar wrote:
> > * Xunlei Pang <xlpang@redhat.com> wrote:
> >
> >> @@ -122,6 +122,10 @@ static int init_pgtable(struct kimage *image, unsigned long start_pgtable)
> >>  
> >>  	level4p = (pgd_t *)__va(start_pgtable);
> >>  	clear_page(level4p);
> >> +
> >> +	if (direct_gbpages)
> >> +		info.direct_gbpages = true;
> > No, this should be keyed off the CPU feature (X86_FEATURE_GBPAGES) automatically, 
> > not set blindly! AFAICS this patch will crash kexec on any CPU that does not 
> > support gbpages.
> 
> It should be fine, probe_page_size_mask() already takes care of this:
>     if (direct_gbpages && boot_cpu_has(X86_FEATURE_GBPAGES)) {
>         printk(KERN_INFO "Using GB pages for direct mapping\n");
>         page_size_mask |= 1 << PG_LEVEL_1G;
>     } else {
>         direct_gbpages = 0;
>     }
> 
> So if X86_FEATURE_GBPAGES is not supported, direct_gbpages will be set to 0.

So why is the introduction of the info.direct_gbpages flag necessary? AFAICS it 
just duplicates the kernel's direct_gbpages flag. One outcome is that hibernation 
won't use gbpages, which is silly.

Thanks,

	Ingo