From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbdEEKHj (ORCPT ); Fri, 5 May 2017 06:07:39 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:59824 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751326AbdEEKHi (ORCPT ); Fri, 5 May 2017 06:07:38 -0400 Date: Fri, 5 May 2017 03:07:29 -0700 From: Christoph Hellwig To: Geert Uytterhoeven Cc: Ingo Molnar , Peter Zijlstra , Oleg Nesterov , Thomas Gleixner , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org Subject: Re: [PATCH/RFC] signal: Export signal_wake_up_state() to modules Message-ID: <20170505100729.GA21589@infradead.org> References: <1493977751-19340-1-git-send-email-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1493977751-19340-1-git-send-email-geert+renesas@glider.be> User-Agent: Mutt/1.8.0 (2017-02-23) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 11:49:11AM +0200, Geert Uytterhoeven wrote: > When using signal_wake_up() from a loadable kernel module: > > ERROR: "signal_wake_up_state" [drivers/spi/spi-sh-msiof.ko] undefined! > > Export signal_wake_up_state() to modules to fix this. Or rever the commit that added the users. This doesn't look like functionality a driver should use..