Re: [PATCH 3.18 36/68] Handle mismatched open calls

Greg Kroah-Hartman
2017-11-15T09:08:14Z

On Fri, Jul 14, 2017 at 05:42:32PM +0100, Ben Hutchings wrote:
> On Fri, 2017-05-05 at 11:32 -0700, Greg Kroah-Hartman wrote:
> > 3.18-stable review patch.  If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Sachin Prabhu <sprabhu@redhat.com>
> >
> > commit 38bd49064a1ecb67baad33598e3d824448ab11ec upstream.
> [...]
> > --- a/fs/cifs/smb2ops.c
> > +++ b/fs/cifs/smb2ops.c
> > @@ -1461,6 +1461,8 @@ struct smb_version_operations smb21_oper
> >   .clear_stats = smb2_clear_stats,
> >   .print_stats = smb2_print_stats,
> >   .is_oplock_break = smb2_is_valid_oplock_break,
> > + .handle_cancelled_mid = smb2_handle_cancelled_mid,
> > + .handle_cancelled_mid = smb2_handle_cancelled_mid,
> >   .downgrade_oplock = smb2_downgrade_oplock,
> >   .need_neg = smb2_need_neg,
> >   .negotiate = smb2_negotiate,
> > @@ -1542,6 +1544,8 @@ struct smb_version_operations smb30_oper
> >   .print_stats = smb2_print_stats,
> >   .dump_share_caps = smb2_dump_share_caps,
> >   .is_oplock_break = smb2_is_valid_oplock_break,
> > + .handle_cancelled_mid = smb2_handle_cancelled_mid,
> > + .handle_cancelled_mid = smb2_handle_cancelled_mid,
> >   .downgrade_oplock = smb2_downgrade_oplock,
> >   .need_neg = smb2_need_neg,
> >   .negotiate = smb2_negotiate,
> [...]
>
> This doesn't look right. handle_cancelled_mid should be initialised
> once in each of the 3 smb_version_operations structures, shouldn't it?

Yeah, something is odd with this, I'll look into it later today, thanks
for flagging it.

greg k-h