From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755442AbdEETno (ORCPT ); Fri, 5 May 2017 15:43:44 -0400 Received: from one.firstfloor.org ([193.170.194.197]:44366 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753654AbdEETnn (ORCPT ); Fri, 5 May 2017 15:43:43 -0400 Date: Fri, 5 May 2017 12:43:40 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields Message-ID: <20170505194340.GU22592@two.firstfloor.org> References: <20170501194746.10296-1-andi@firstfloor.org> <20170502064147.GB23708@krava> <20170504222620.GT22592@two.firstfloor.org> <20170505075754.GA7540@krava> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505075754.GA7540@krava> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 09:57:54AM +0200, Jiri Olsa wrote: > On Thu, May 04, 2017 at 03:26:20PM -0700, Andi Kleen wrote: > > On Tue, May 02, 2017 at 08:41:47AM +0200, Jiri Olsa wrote: > > > On Mon, May 01, 2017 at 12:47:46PM -0700, Andi Kleen wrote: > > > > From: Andi Kleen > > > > > > > > With perf script it is common that we just want to add or remove a field. > > > > Currently this requires figuring out the long list of default fields and > > > > specifying them first, and then adding/removing the new field. > > > > > > > > This patch adds a new + - syntax to merely add or remove fields, > > > > that allows more succint and clearer command lines > > > > > > > > For example to remove the comm field from PMU samples: > > > > > > > > Previously > > > > > > > > perf script -F pid,cpu,time,event,sym,ip,dso,period > > > > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms]) > > > > > > > > with the new syntax > > > > > > > > perf script -F -comm > > > > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms]) > > > > > > > > > I haven't checked deeply yet, but I'm getting different pids > > > with the new syntax, perhaps some mixing with tids column? > > > > Cannot reproduce. Do you have an exact command line? > > > > The patch shouldn't really change any columns. > > > > [jolsa@krava perf]$ ./perf record -a I looked at this, and I don't think it's different with my patch. Any time you set fields you get different output versus default: % perf script -F pid,cpu,time,event,sym,ip,dso,period,comm vs % perf script First gives PID second TID. It would be good to fix, but I don't think it should block my patch. -Andi