From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755611AbdEEUxx (ORCPT ); Fri, 5 May 2017 16:53:53 -0400 Received: from mail-wr0-f171.google.com ([209.85.128.171]:32785 "EHLO mail-wr0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbdEEUxv (ORCPT ); Fri, 5 May 2017 16:53:51 -0400 Date: Fri, 5 May 2017 21:53:49 +0100 From: Matt Fleming To: Geliang Tang Cc: Ivan Hu , Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] efi/efi_test: use memdup_user Message-ID: <20170505205349.GC5225@codeblueprint.co.uk> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 29 Apr, at 09:42:52AM, Geliang Tang wrote: > Use memdup_user() helper instead of open-coding to simplify the code. > > Signed-off-by: Geliang Tang > --- > drivers/firmware/efi/test/efi_test.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) This one looks fine. Ivan, do you want to ACK it?