From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755315AbdEEVVt (ORCPT ); Fri, 5 May 2017 17:21:49 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:37405 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754316AbdEEVVr (ORCPT ); Fri, 5 May 2017 17:21:47 -0400 Date: Fri, 5 May 2017 22:21:45 +0100 From: Matt Fleming To: Fabian Frederick Cc: Ard Biesheuvel , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Kweh Hock Leong Subject: Re: [PATCH 1/1 linux-next] efi/capsule: kmap() can't fail Message-ID: <20170505212145.GE5225@codeblueprint.co.uk> References: <20170425181051.2187-1-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170425181051.2187-1-fabf@skynet.be> User-Agent: Mutt/1.5.24+41 (02bc14ed1569) (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Apr, at 08:10:51PM, Fabian Frederick wrote: > Remove NULL test on kmap() > > Signed-off-by: Fabian Frederick > --- > drivers/firmware/efi/capsule-loader.c | 5 ----- > drivers/firmware/efi/capsule.c | 4 ---- > 2 files changed, 9 deletions(-) > > diff --git a/drivers/firmware/efi/capsule-loader.c b/drivers/firmware/efi/capsule-loader.c > index 9ae6c11..bf8b2ef 100644 > --- a/drivers/firmware/efi/capsule-loader.c > +++ b/drivers/firmware/efi/capsule-loader.c > @@ -183,11 +183,6 @@ static ssize_t efi_capsule_write(struct file *file, const char __user *buff, > page = cap_info->pages[cap_info->index - 1]; > > kbuff = kmap(page); > - if (!kbuff) { > - pr_debug("%s: kmap() failed\n", __func__); > - ret = -EFAULT; > - goto failed; > - } > kbuff += PAGE_SIZE - cap_info->page_bytes_remain; > > /* Copy capsule binary data from user space to kernel space buffer */ > diff --git a/drivers/firmware/efi/capsule.c b/drivers/firmware/efi/capsule.c > index 6eedff4..e603ccf 100644 > --- a/drivers/firmware/efi/capsule.c > +++ b/drivers/firmware/efi/capsule.c > @@ -247,10 +247,6 @@ int efi_capsule_update(efi_capsule_header_t *capsule, struct page **pages) > efi_capsule_block_desc_t *sglist; > > sglist = kmap(sg_pages[i]); > - if (!sglist) { > - rv = -ENOMEM; > - goto out; > - } > > for (j = 0; j < SGLIST_PER_PAGE && count > 0; j++) { > u64 sz = min_t(u64, imagesize, PAGE_SIZE); Huh, well I didn't know that. This looks OK to me. Applied, thanks.