From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757028AbdEGW02 (ORCPT ); Sun, 7 May 2017 18:26:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33350 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756814AbdEGW0Z (ORCPT ); Sun, 7 May 2017 18:26:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 0763764D32 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jolsa@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 0763764D32 Date: Sun, 7 May 2017 16:08:48 +0200 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools, script: Allow adding and removing fields Message-ID: <20170507140848.GA12604@krava> References: <20170501194746.10296-1-andi@firstfloor.org> <20170502064147.GB23708@krava> <20170504222620.GT22592@two.firstfloor.org> <20170505075754.GA7540@krava> <20170505194340.GU22592@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170505194340.GU22592@two.firstfloor.org> User-Agent: Mutt/1.8.0 (2017-02-23) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Sun, 07 May 2017 14:08:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 05, 2017 at 12:43:40PM -0700, Andi Kleen wrote: > On Fri, May 05, 2017 at 09:57:54AM +0200, Jiri Olsa wrote: > > On Thu, May 04, 2017 at 03:26:20PM -0700, Andi Kleen wrote: > > > On Tue, May 02, 2017 at 08:41:47AM +0200, Jiri Olsa wrote: > > > > On Mon, May 01, 2017 at 12:47:46PM -0700, Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > > > > > With perf script it is common that we just want to add or remove a field. > > > > > Currently this requires figuring out the long list of default fields and > > > > > specifying them first, and then adding/removing the new field. > > > > > > > > > > This patch adds a new + - syntax to merely add or remove fields, > > > > > that allows more succint and clearer command lines > > > > > > > > > > For example to remove the comm field from PMU samples: > > > > > > > > > > Previously > > > > > > > > > > perf script -F pid,cpu,time,event,sym,ip,dso,period > > > > > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms]) > > > > > > > > > > with the new syntax > > > > > > > > > > perf script -F -comm > > > > > 0 [000] 504345.383126: 1 cycles: ffffffff90060c66 native_write_msr ([kernel.kallsyms]) > > > > > > > > > > > > I haven't checked deeply yet, but I'm getting different pids > > > > with the new syntax, perhaps some mixing with tids column? > > > > > > Cannot reproduce. Do you have an exact command line? > > > > > > The patch shouldn't really change any columns. > > > > > > > [jolsa@krava perf]$ ./perf record -a > > I looked at this, and I don't think it's different with my patch. > > Any time you set fields you get different output versus default: > > > % perf script -F pid,cpu,time,event,sym,ip,dso,period,comm > > vs > > % perf script > > First gives PID second TID. > > It would be good to fix, but I don't think it should block my patch. your changelog says those 2 commands give same output, so either fix the changelog or provide related fix thanks, jirka